Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auth page #53

Merged
merged 100 commits into from
Jan 20, 2025
Merged

Auth page #53

merged 100 commits into from
Jan 20, 2025

Conversation

michaelbrusegard
Copy link
Member

No description provided.

@ZeroWave022 ZeroWave022 linked an issue Sep 26, 2024 that may be closed by this pull request
feat: auth page #52
Closed
@michaelbrusegard
chore: update dockerfile context
dc62dc2
@michaelbrusegard
fix: logo props
378ffca
@michaelbrusegard
Merge branch 'dev' into auth-page
29eb618
@michaelbrusegard
chore: fix padding on main element to not remove background
6f762fe
@michaelbrusegard
typo: correct language to use sign in instead of login
8033626
@michaelbrusegard
chore: add main element to error pages
3792169
@michaelbrusegard
feat: tailwindcss plugins
c3e83f7
@michaelbrusegard
fix: formatting errors
31973c3
@michaelbrusegard
chore: add separator role
31ecf7f
@michaelbrusegard
perf: replace size with h and w everywhere to improve performance
28f6aad
@michaelbrusegard
fix: os specific syntax for lefthook install
7cc2129
@michaelbrusegard
feat: made header logo responsive transition smooth
a01f0be
@michaelbrusegard
Merge branch 'dev' into auth-page
03de392
@michaelbrusegard
cchroe: cleanup docker and package.json
b0b88b0
@michaelbrusegard
chore: cleanup api
4482f45
@michaelbrusegard
feat: update middleware
7f5fc36
@michaelbrusegard
feat: add success particles
53d4e94
@michaelbrusegard
fix: badge not being hoverable
5561c91
@michaelbrusegard
feat: add account signin form
a34397c
@michaelbrusegard
feat: seperate out tables and add seeding
1343259
@michaelbrusegard
feat: setup password and session auth methods
5351dd3
@michaelbrusegard michaelbrusegard marked this pull request as ready for review January 16, 2025 10:48
@michaelbrusegard
Copy link
Member Author

lighthouse workflow will fail since we do not have a way of it connecting to a database when it runs the build yet. But that should be a separate issue

@michaelbrusegard
Copy link
Member Author

Also profile and account settings page will be its own issue. And forgot password requests will be its own issue

@michaelbrusegard
Copy link
Member Author

Now that this is done the backend is fully working and up and running. And authentication with and without Feide should work. If you want to test you can login with the Frank Sinatra account which is currently being seeded to the database.
Username: fransina
Password: Password1!

@michaelbrusegard michaelbrusegard requested review from HaakonWiland and removed request for ZeroWave022 January 16, 2025 16:09
HaakonWiland
HaakonWiland approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@HaakonWiland HaakonWiland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, lets merge yolo

seandreassen
seandreassen requested changes Jan 16, 2025
View reviewed changes
Copy link
Member

@seandreassen seandreassen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't really look through thoroughly, and couldn't run the website so I don't know if the CSS looks good. I'm sure most of it works but it should probably be reviewed by someone else as well.

src/components/composites/PasswordInput.tsx Outdated Show resolved Hide resolved
src/lib/constants.ts Outdated Show resolved Hide resolved
src/lib/locale/index.ts Outdated Show resolved Hide resolved
src/server/auth/user.ts Show resolved Hide resolved
@michaelbrusegard michaelbrusegard mentioned this pull request Jan 20, 2025
Merged
@michaelbrusegard michaelbrusegard merged commit 11bdc0c into dev Jan 20, 2025
2 of 3 checks passed
@michaelbrusegard michaelbrusegard deleted the auth-page branch January 20, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeroWave022 ZeroWave022 ZeroWave022 left review comments

@seandreassen seandreassen seandreassen requested changes

@HaakonWiland HaakonWiland HaakonWiland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: auth page
4 participants
@michaelbrusegard @ZeroWave022 @HaakonWiland @seandreassen