Rules page #60
Rules page #60
Conversation
There was a problem hiding this comment.
I just looked at the code right now, but I also think the styling can be improved. Maybe look at some other websites or examples and try to get inspiration. Also you can look at more "fancy" components to add to learn about that and it can be fun to work on, like aceturnity etc
There was a problem hiding this comment.
Please also merge dev into your branch, run bun install, and take a look at other pages for examples of how to migrate to Next.js 15. Most notably, pages need to be async and we await params now, so a little different (but this can be copy-pasted from other pages)
|
As for the design, I really like it. But the hover effect should probably be made faster. Also I am not sure about why we need to write internal rules on every single internal rules page when they are all in the same list and some other inconsistancies , but it is probably good enough for now. |
|
Also I was a little strict, but it is probably fine so if you disagree or I misunderstood you can probably just resolve the comment! |
|
This can be merged whenever I think? |
|
Yes, but I will double check some things on the next meeting 😅. |
First attempt at creating rules page, open for reviews and suggestions.
Created rules page, necessary mock-data and components, and routing to subpages,
Have only implemented a temporary 'design' of how I want the page to look. Don't think i used the proper approach to using components and/or creating components. Would therefore like suggestions on how i could improve or refractor the actual code, current design of the page, improper use of tailwind properties, or any other areas of improvements.
Closes #18.