About us page and group pages #62
Conversation
|
Im gonna fix commit messages real quick. Next time dont use norwegian and use the conventional commit standard on all messages :) |
|
Cant do it because they are signed... Fixing it by installing lazygit on your pc |
…, breaboard computer, ttrpg, and game projects, and member representative
supattrw
force-pushed
the
about-us-page
branch
from
8a7735c
to
a96b333
Compare
|
We were not able to fix all commit messages unfortunately but that is fine |
|
The biggest issue is that you are not reusing components. Try to create more files of smaller building blocks |
michaelbrusegard
changed the title
|
@supattrw IF you want you can focus on the main about page in this PR and the group pages can be separate PRs. I think that would be a very good idea so other people can work on the individual pages too as they finish other parts of the website |
|
Waiting until all of Michael's comments are resolved before submitting my own review. |
| @@ -36,7 +36,6 @@ | |||
| "navigationMenu": "Navigation menu", | |||
| "news": "News", | |||
| "events": "Events", | |||
| "storage": "Storage", | |||
| @@ -45,7 +46,7 @@ | |||
| "cva": "^1.0.0-beta.1", | |||
| "date-fns": "^4.1.0", | |||
| "drizzle-orm": "^0.33.0", | |||
| "lucia": "3.2.0", | |||
| "lucia": "^3.2.0", | |||
| const images = [ | ||
| { id: "image1", src: "/unknown.png", alt: "unknown" }, | ||
| { id: "image2", src: "/mock.jpg", alt: "mock" }, | ||
| { id: "image3", src: "/bg.jpg", alt: "bg" }, | ||
| { id: "image4", src: "/about/pizzaWolfs-min.png", alt: "pizzaWolfs" }, | ||
| ]; |
There was a problem hiding this comment.
Alts for images should be descriptive
| const t = useTranslations('labops'); | ||
|
|
||
| return ( | ||
| <div> |
There was a problem hiding this comment.
Doesn't look like the div is strictly necessary here
| <h1 className='mt-4 mb-4 w-full'> DevOps </h1> | ||
| <div className='flex w-full'> {t('about')} </div> |
There was a problem hiding this comment.
| <h1 className='mt-4 mb-4 w-full'> DevOps </h1> | |
| <div className='flex w-full'> {t('about')} </div> | |
| <h1 className='mt-4 mb-4 w-full'>DevOps</h1> | |
| <div className='flex w-full'>{t('about')}</div> |
| <div> | ||
| <h3 className='mb-2'> {t('financialManager')} </h3> | ||
| <Card className='p-20'> | ||
| <CardHeader> Økonomiansvarlig </CardHeader> |
There was a problem hiding this comment.
| <CardHeader> Økonomiansvarlig </CardHeader> | |
| <CardHeader>Økonomiansvarlig</CardHeader> |
|
|
||
| return ( | ||
| <div> | ||
| <h1 className='mt-4 flex w-full items-center justify-center dark:text-primary'> Member Representative </h1> |
There was a problem hiding this comment.
| <h1 className='mt-4 flex w-full items-center justify-center dark:text-primary'> Member Representative </h1> | |
| <h1 className='mt-4 flex w-full items-center justify-center dark:text-primary'>Member Representative</h1> |
| p1: (chunks) => <p className="p1"> {chunks} </p>, | ||
| p2: (chunks) => <p className="p2"> {chunks} </p>, | ||
| p3: (chunks) => <p className="p3"> {chunks} </p> | ||
| })} |
There was a problem hiding this comment.
| p1: (chunks) => <p className="p1"> {chunks} </p>, | |
| p2: (chunks) => <p className="p2"> {chunks} </p>, | |
| p3: (chunks) => <p className="p3"> {chunks} </p> | |
| })} | |
| p1: (chunks) => <p className="p1">{chunks}</p>, | |
| p2: (chunks) => <p className="p2">{chunks}</p>, | |
| p3: (chunks) => <p className="p3">{chunks}</p> | |
| })} |
| type images = { | ||
| id: string; | ||
| src: string; | ||
| alt: string; | ||
| }; | ||
|
|
||
| type ImageCarouselProps = { | ||
| images: images[]; | ||
| }; |
There was a problem hiding this comment.
| type images = { | |
| id: string; | |
| src: string; | |
| alt: string; | |
| }; | |
| type ImageCarouselProps = { | |
| images: images[]; | |
| }; | |
| type ImageCarouselProps = { | |
| images: { | |
| id: string; | |
| src: string; | |
| alt: string; | |
| }[]; | |
| }; |
| type Member = { | ||
| name: string; | ||
| image: string; | ||
| }; | ||
|
|
||
| type MembersTableProps = { | ||
| Members: Member[]; | ||
| }; |
There was a problem hiding this comment.
| type Member = { | |
| name: string; | |
| image: string; | |
| }; | |
| type MembersTableProps = { | |
| Members: Member[]; | |
| }; | |
| type MembersTableProps = { | |
| members: { | |
| name: string; | |
| image: string; | |
| }[]; | |
| }; |
these is the pages that is worth to take a look at ...??
not done (but technocally same layout)
under leader and deputy leader (in devops etc.), Im thinking of using Lisa's member-component.
please give me a better solution to create a table for 'list of all members'
the accordion component is meant to look like the one in aboutPage
the FAQ's is not done
Please be kind 😭😭😭