-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add events page #66
Conversation
The ARIA label is placed correctly, however lighthouse can't find which text it's referring to
Event card skeleton is slightly shorter than event card. |
tell me when this needs to be rereviewed |
All issues should have been looked at now and improved.
|
@michaelbrusegard asking you explicitly like you mentioned above |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Need to implement the Link.tsx component.
- Some questions
Any controversial changes have been commented and the conversations are open. Feel free to let me know about your thoughts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of it looks good! A bit weird having external link used as links to the same page, but if you're supposed to use that link for links to the same page then I probably should've picked a better name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
The page lists events, separated into active, upcoming and past events.
There's also a separate page each event, so more information can be shown.