Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add events page #66

Merged
merged 60 commits into from
Jan 28, 2025
Merged

feat: Add events page #66

merged 60 commits into from
Jan 28, 2025

Conversation

ZeroWave022
Copy link
Member

@ZeroWave022 ZeroWave022 commented Oct 24, 2024

The page lists events, separated into active, upcoming and past events.
There's also a separate page each event, so more information can be shown.

  • Main page for events
  • Events are grouped into internal and open events
  • Own pages for each event

@ZeroWave022 ZeroWave022 marked this pull request as ready for review October 31, 2024 18:13
The ARIA label is placed correctly, however lighthouse can't find which text it's referring to
@seandreassen
Copy link
Member

Suspense looks horrible on small screens, you have probably haven't updated layout.tsx after updating page.tsx.
bilde

@seandreassen
Copy link
Member

Event card skeleton is slightly shorter than event card.

@seandreassen
Copy link
Member

Maybe this large block of text should be replaced by the same type of event skeleton as below it.
bilde

src/app/[locale]/(default)/events/page.tsx Outdated Show resolved Hide resolved
src/app/[locale]/(default)/events/page.tsx Outdated Show resolved Hide resolved
src/app/[locale]/(default)/events/loading.tsx Outdated Show resolved Hide resolved
src/components/events/EventCardSkeleton.tsx Show resolved Hide resolved
src/app/[locale]/(default)/events/[id]/loading.tsx Outdated Show resolved Hide resolved
src/app/[locale]/(default)/events/[id]/layout.tsx Outdated Show resolved Hide resolved
@michaelbrusegard
Copy link
Member

tell me when this needs to be rereviewed

@ZeroWave022
Copy link
Member Author

All issues should have been looked at now and improved.
The event card skeletons are still <10 px different from the real content. There are too many variables to account for here to make this perfect - whether the event is internal, title & description length, image size (this should be limited correctly though) and so on. Although, when testing with no internal events (set internal to false in the mock data), the skeletons seem to work quite well on desktop and mobile.

  • Badge has no tooltip
  • Hover effect to the cards has been added
  • Ring effect for keyboard use is fixed
  • Headings are clickable and send you up/down on the page
  • Time text is now bold

@ZeroWave022
Copy link
Member Author

@michaelbrusegard asking you explicitly like you mentioned above

@ZeroWave022 ZeroWave022 linked an issue Jan 25, 2025 that may be closed by this pull request
Copy link
Member

@michaelbrusegard michaelbrusegard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Need to implement the Link.tsx component.
  • Some questions

messages/en.json Outdated Show resolved Hide resolved
public/event.webp Outdated Show resolved Hide resolved
src/app/[locale]/(default)/events/loading.tsx Outdated Show resolved Hide resolved
src/app/[locale]/(default)/events/loading.tsx Outdated Show resolved Hide resolved
src/app/[locale]/(default)/events/page.tsx Outdated Show resolved Hide resolved
src/components/events/EventCard.tsx Show resolved Hide resolved
src/components/events/EventCard.tsx Show resolved Hide resolved
src/components/ui/Avatar.tsx Show resolved Hide resolved
@ZeroWave022
Copy link
Member Author

Any controversial changes have been commented and the conversations are open. Feel free to let me know about your thoughts

Copy link
Member

@seandreassen seandreassen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of it looks good! A bit weird having external link used as links to the same page, but if you're supposed to use that link for links to the same page then I probably should've picked a better name.

src/app/[locale]/(default)/events/page.tsx Outdated Show resolved Hide resolved
src/app/[locale]/(default)/events/[id]/loading.tsx Outdated Show resolved Hide resolved
Copy link
Member

@seandreassen seandreassen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@ZeroWave022 ZeroWave022 merged commit f4bbcb4 into dev Jan 28, 2025
3 of 4 checks passed
@ZeroWave022 ZeroWave022 deleted the events branch January 28, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Events page
3 participants