-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add drf opportunities #266
Add drf opportunities #266
Conversation
…d .gitignore lines and rename compose for staging
* Update app/config/settings.py Co-authored-by: Kevin Park <[email protected]> Co-authored-by: Ava Li <[email protected]>
Fix compose stage
…nstructions to the installation README
…nd-formatter Add pre commit for python linter and formatter
* added new libraries * added notes to documentation * added preliminary tests and gha * added user interaction lib * added async tests * added note to self * updated tests * added transition library * added new library to better support transitions * finished writing tests for landing page * reorganized test files * moves test files to new location * moved file mocks * testing new tab width * corrected lint * added custom extension to mkdocs * added credit for source code * streamlined dockerfile * removed start lines * configured dockerfile * wrote test architecture info to docs * lint fixes * reverted readme indents * empty commit * test * test * lint errors * lint fixes * added alt text * added dev-branch to linter
* renamed components * added new custom linter * added a11y linter to GHA * shortened code * linting entire codebase * configured linter settings * rewrote config in yml format * testing * added defaults for eslint * copied over default lint configs * testing linter * testing linter * testing * added axe-react to test code * fixed accessibility errors * corrected for accessible tabbing * added wrapper for onenter events * added on key wrapper function for events * cleaned comments * separated dialog backdrop from component * fixed tests * added documentation on accessibility testing * added links to documentation * corrected for linter * pooled resources to all be in mkdocs * reverted lint configs * added template credits
* added react 18 and updated dependencies * opened react in strictmode * fixed dialog error due to batched rerendering * added transition ref for findDomNode deprecation * added useeffect to better handle state setting
* simplified landing page intro * adjusted sizes to add background * adjusted landing backgrounds * adjusted css * added tests * linter fixs
* added doc notes * added options to svgr * created svgWrapper * wrapped svgs for built in accessibility
* completed first draft * moved svgs to dedicated directories * addec checkboxes svgs * adding state for checkbox * configured checkbox colors * adjusted checkbox parent element * created rudamentary checkbox * added background hover * corrected for accessibility * completed component * removed checkbox role for parent * simplified accessibility * refactored code * adjusted event listeners * fixed hidden label prop * corrected focus * started checkbox tests * added tests
* created first draft of textfield * fixed checkbox pointer rules * added new icons * created textfield with icons * updated demo to showcase icon toggle * replaced eye closed icon * lint changes * lint corrections * added change callback for inputs * added tests * added type prop * updated tests
…d .gitignore lines and rename compose for staging
…nstructions to the installation README
@Enzyme3 Feel free to ignore the linting error for now. It probably resulted from the way the branching was done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll need some time to do a full review, but here's a quick note you might want to take a look at.
I'm assuming this was a result of whatever happened with your branch?
app/config/settings.py
Outdated
COMMON_MIDDLEWARE = [ | ||
"django.middleware.security.SecurityMiddleware", | ||
"django.contrib.sessions.middleware.SessionMiddleware", | ||
"django.middleware.common.CommonMiddleware", | ||
"django.middleware.csrf.CsrfViewMiddleware", | ||
"django.contrib.auth.middleware.AuthenticationMiddleware", | ||
"django.contrib.messages.middleware.MessageMiddleware", | ||
"django.middleware.clickjacking.XFrameOptionsMiddleware", | ||
] | ||
|
||
MIDDLEWARE = [ | ||
'django.middleware.security.SecurityMiddleware', | ||
'django.contrib.sessions.middleware.SessionMiddleware', | ||
'django.middleware.common.CommonMiddleware', | ||
'django.middleware.csrf.CsrfViewMiddleware', | ||
'django.contrib.auth.middleware.AuthenticationMiddleware', | ||
'django.contrib.messages.middleware.MessageMiddleware', | ||
'django.middleware.clickjacking.XFrameOptionsMiddleware', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change broke the Django server.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, looks like the ]
somehow got dropped. Added it, and re-ran the linter which also changed the single quotes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! Thanks for working on this!
Fixes #220
Apologies... not sure why all the previous commits are listed out here - tried squashing them but doesn't seem to work. I'll try to fix it before raising any other PRs.
Changes
skills
To see in action, bring up app via
docker compose
and access endpoint viahttp://localhost:8000/api/v1/opportunitites/
To load sample data, run
docker compose run django python manage.py loaddata test_data.yaml