Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing staging deployment attempt 2 #433

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

MattPereira
Copy link
Contributor

@MattPereira MattPereira commented Aug 21, 2023

Fixes #430 ( hopefully )

Changes

  • I opted to run poetry lock instead of poetry lock --no-cache to let poetry upgrade packages which will hopefully allow for the incompatible version issue involving pyyaml and cython ( see comment on poetry repo )
  • This resulted in the poetry.lock file upgrading the version of pyyaml to 6.0.1 which the comment with multiple thumbs ups indicates will fix the incompatibility

Discussion

  • My understanding is that the poetry.lock file determines which versions of packages end up being installed and made available to the docker container as the Build, tag, and push image to Amazon ECR job runs
  • If anyone is nervous about the number of upgraded packages in the poetry.lock file please voice your opinion. I lean towards its fine to let poetry lock command do its thing. I did run a full docker compose build --no-cache and site still looks good on my local environment

Discovery

  • If you are running ubuntu desktop, you are not supposed to change the default version of python because much of the software that runs on your local machine depends on the exact version that ships with the distro. Instead use pyenv to change the version for a specific terminal instance

Comment on lines 152 to +154
[[package]]
name = "pyyaml"
version = "6.0"
version = "6.0.1"
Copy link
Contributor Author

@MattPereira MattPereira Aug 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pyyaml upgraded here ☝️

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YAAAASSSS!!!

@blulady blulady merged commit e006429 into hackforla:main Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Staging Deployment
2 participants