Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace html elements with MUI components in upcomingEvent.jsx #1842

Merged

Conversation

amachad4
Copy link
Member

@amachad4 amachad4 commented Jan 22, 2025

Fixes #1617

What changes did you make and why did you make them ?

  • Replaced HTML div tag with MUI Box componenet
  • Replaced HTML p tag with MUI Typography component
  • Added 12pt of margin left between ClockIcon and LocationIcon components and their respective text for cleaner spacing
  • WHY: To modernize the upcomingEvent.jsx component using MUI

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

upcomingEvent_Before

Visuals after changes are applied

upcomingEvent_After

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b amachad4-update-html-to-mui-upcomingEvents development
git pull https://github.com/amachad4/VRMS.git update-html-to-mui-upcomingEvents

Copy link
Member

@trillium trillium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean and clear changes, thank you!

@trillium trillium merged commit 96b6a92 into hackforla:development Jan 27, 2025
2 of 5 checks passed
@amachad4 amachad4 linked an issue Jan 28, 2025 that may be closed by this pull request
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants