updating group name in assignment

[chelseybeck]

What changed?

• after changing the group and policy names, I didn't update the name of the group users were assigned to...correcting that

[github-actions]

Terraform plan in terraform

Plan: 1 to add, 1 to change, 2 to destroy.

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+   create
!~  update in-place
-   destroy

Terraform will perform the following actions:

  # module.aws_custom_policies.aws_iam_policy.custom_policy["IAMServicesAdmin"] will be destroyed
  # (because key ["IAMServicesAdmin"] is not in for_each map)
-   resource "aws_iam_policy" "custom_policy" {
-       arn         = "arn:aws:iam::035866691871:policy/IAMServicesAdmin" -> null
-       description = "Policy granting IAM services admins permissions to make changes to user accounts" -> null
-       id          = "arn:aws:iam::035866691871:policy/IAMServicesAdmin" -> null
-       name        = "IAMServicesAdmin" -> null
-       path        = "/" -> null
-       policy      = jsonencode(
            {
-               Statement = [
-                   {
-                       Action   = [
-                           "iam:CreateAccessKey",
                        ]
-                       Effect   = "Allow"
-                       Resource = "arn:aws:iam::*:user/*"
                    },
-                   {
-                       Action    = [
-                           "iam:UpdateLoginProfile",
                        ]
-                       Condition = {
-                           StringEquals = {
-                               "iam:ResourceTag/Access Level" = [
-                                   "1",
-                                   "2",
                                ]
                            }
                        }
-                       Effect    = "Allow"
-                       Resource  = "arn:aws:iam::*:user/*"
                    },
-                   {
-                       Action   = [
-                           "cloudshell:CreateEnvironment",
-                           "cloudshell:GetEnvironmentStatus",
-                           "cloudshell:CreateSession",
-                           "cloudshell:StartEnvironment",
-                           "cloudshell:StopEnvironment",
                        ]
-                       Effect   = "Allow"
-                       Resource = "*"
                    },
                ]
-               Version   = "2012-10-17"
            }
        ) -> null
-       policy_id   = "ANPAQQWOSJEPRL2DTHOJL" -> null
-       tags        = {} -> null
-       tags_all    = {} -> null
    }

  # module.iam_services_admin_group.aws_iam_group.group will be destroyed
  # (because aws_iam_group.group is not in configuration)
-   resource "aws_iam_group" "group" {
-       arn       = "arn:aws:iam::035866691871:group/iam-services-admin-group" -> null
-       id        = "iam-services-admin-group" -> null
-       name      = "iam-services-admin-group" -> null
-       path      = "/" -> null
-       unique_id = "AGPAQQWOSJEPURLU5DTDL" -> null
    }

  # module.iam_services_supervisor_group.aws_iam_group_policy_attachment.group_policy_attachment["IAMServicesSupervisor"] will be created
+   resource "aws_iam_group_policy_attachment" "group_policy_attachment" {
+       group      = "iam-services-supervisor-group"
+       id         = (known after apply)
+       policy_arn = "arn:aws:iam::035866691871:policy/IAMServicesSupervisor"
    }

  # module.iam_user_chelseyb.aws_iam_user_group_membership.user_group_membership will be updated in-place
!~  resource "aws_iam_user_group_membership" "user_group_membership" {
!~      groups = [
-           "iam-services-admin-group",
+           "iam-services-supervisor-group",
#            (1 unchanged element hidden)
        ]
        id     = "terraform-20240222055701939500000001"
#        (1 unchanged attribute hidden)
    }

Plan: 1 to add, 1 to change, 2 to destroy.

❌ Error applying plan in Apply Terraform changes on merge #5

[github-actions]

Terraform plan in terraform

Plan: 1 to add, 0 to change, 1 to destroy.

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+   create
-   destroy

Terraform will perform the following actions:

  # module.aws_custom_policies.aws_iam_policy.custom_policy["IAMServicesAdmin"] will be destroyed
  # (because key ["IAMServicesAdmin"] is not in for_each map)
-   resource "aws_iam_policy" "custom_policy" {
-       arn         = "arn:aws:iam::035866691871:policy/IAMServicesAdmin" -> null
-       description = "Policy granting IAM services admins permissions to make changes to user accounts" -> null
-       id          = "arn:aws:iam::035866691871:policy/IAMServicesAdmin" -> null
-       name        = "IAMServicesAdmin" -> null
-       path        = "/" -> null
-       policy      = jsonencode(
            {
-               Statement = [
-                   {
-                       Action   = [
-                           "iam:CreateAccessKey",
                        ]
-                       Effect   = "Allow"
-                       Resource = "arn:aws:iam::*:user/*"
                    },
-                   {
-                       Action    = [
-                           "iam:UpdateLoginProfile",
                        ]
-                       Condition = {
-                           StringEquals = {
-                               "iam:ResourceTag/Access Level" = [
-                                   "1",
-                                   "2",
                                ]
                            }
                        }
-                       Effect    = "Allow"
-                       Resource  = "arn:aws:iam::*:user/*"
                    },
-                   {
-                       Action   = [
-                           "cloudshell:CreateEnvironment",
-                           "cloudshell:GetEnvironmentStatus",
-                           "cloudshell:CreateSession",
-                           "cloudshell:StartEnvironment",
-                           "cloudshell:StopEnvironment",
                        ]
-                       Effect   = "Allow"
-                       Resource = "*"
                    },
                ]
-               Version   = "2012-10-17"
            }
        ) -> null
-       policy_id   = "ANPAQQWOSJEPRL2DTHOJL" -> null
-       tags        = {} -> null
-       tags_all    = {} -> null
    }

  # module.iam_services_supervisor_group.aws_iam_group_policy_attachment.group_policy_attachment["IAMServicesSupervisor"] will be created
+   resource "aws_iam_group_policy_attachment" "group_policy_attachment" {
+       group      = "iam-services-supervisor-group"
+       id         = (known after apply)
+       policy_arn = "arn:aws:iam::035866691871:policy/IAMServicesSupervisor"
    }

Plan: 1 to add, 0 to change, 1 to destroy.

✅ Plan applied in Apply Terraform changes on merge #5