Create table project status 46

[dmartin4820]

Fixes #46

What changes did you make?

• created project_status model
• register project_status in admin
• add project_status endpoints
• add project_status seed data

Why did you make the changes (we will use this info to test)?

N/A

[del9ra]

Hi Denzel,
Thank you for working on this! I tested it, and everything worked well on my end. I just have a couple of questions:

1. Why are the descriptions on the 5th and 6th lines in quotation marks in the app/core/initial_data/PD_Table and Field Explanations - ProjectStatus - Data.csv file? Do you think this has an impact on how the code works?
2. Shouldn't the uuid field be mentioned in the _seed.py file?

[dmartin4820]

Hi Denzel, Thank you for working on this! I tested it, and everything worked well on my end. I just have a couple of questions:

1. Why are the descriptions on the 5th and 6th lines in quotation marks in the app/core/initial_data/PD_Table and Field Explanations - ProjectStatus - Data.csv file? Do you think this has an impact on how the code works?

2. Shouldn't the uuid field be mentioned in the _seed.py file?

Hey Del, thanks for the comments.

1. I'm unsure how that got that way. The excel sheet doesn't have the quotes. I'll change that.
2. Good point. All the other seed files have UUID, but the table in the Google sheet, for this PR, didn't have an UUID column. @Neecolaa @fyliu Can we make an update to the Project Status table in Google sheets so that it contains an id column? By doing this we would maintain consistency with the other tables and seed data with UUID fields.

[fyliu]

2. Good point. All the other seed files have UUID, but the table in the Google sheet, for this PR, didn't have an UUID column. @Neecolaa @fyliu Can we make an update to the Project Status table in Google sheets so that it contains an id column? By doing this we would maintain consistency with the other tables and seed data with UUID fields.

I guess it depends on if we still need it set to specific values. The values it's being set to in the spreadsheet aren't really UUID values.

Originally, I let the database generate the ID/UUID values since it's an auto-generated field and the initial data sheets didn't have the values. Then @ethanstrominger said he needed to set the values for testing purposes, so we did that for some of the tables. But I don't think it's being used in tests right now?

We should bring this up at the meeting and ask if we still need to set this.

• PeopleDepot Team Meeting Agenda 2025 #461

[del9ra]

Hi @dmartin4820 ,
Thanks for your contribution! Nice work on this, it looks great to me!

[fyliu]

Thanks for working on this! I looked at this more closely and found a couple more things to improve.

[fyliu]

This should be current_status.

The old code was written before we realized Django convention is to drop the _id ending for foreign key relations.

[fyliu]

Sorry, can you add back the double quotes?

I think the double quotes are actually necessary for the convert.py script to work. They're likely added by google to help any csv parser read it.

[dmartin4820]

Added back. It was definitely needed otherwise the csv parser would not run.

[fyliu]

Thanks for making the changes. They look great!

I'm sorry, I just noticed another little thing.

The admin site adds an "s" at the end when displaying the plural form of the model. It doesn't know to use "project statuses".

In models.py you can search for "verbose_name_plural" and use that as an example to add the plural for it. I think you should make it all lowercase and let Django deal with the capitalization. I see the existing code is doing something different.