Skip to content

Design: Close an Issue

Tristan Camacho edited this page Feb 3, 2025 · 3 revisions

Steps to close a design issue

  1. When you have your issue ready for review, leave a progress update as a comment in the issue letting the design leads know that it's ready for the next design meeting and move the issue to the Visual Review column.
  2. The issue will be reviewed at a design meeting.
    • If the design team decides that updates need to be made to the proposed designs, one of the design leads will leave comments in the issue detailing those updates and will move the issue back to the In Progress column.
  3. If the design team approves of the proposed designs, the issue will be brought up at the all-hands meeting for the production, development, and research teams to give their feedback.
    • If the production, development, or research teams decide that updates need to be made to the proposed designs, one of the design leads will leave comments in the issue detailing those updates and will move the issue back to the In Progress column.
  4. If the production, development, and research teams approve of the proposed designs:
    • the assignee must update the relevant slide in the Staging Deck with mockups and any information necessary to explain the reasoning for the designs to the stakeholders at the next stakeholder meeting. The assignee then must move the slide to the next Stakeholder Deck.
    • the assignee moves the issue to the Questions/Clarifications column and adds the "Waiting for Stakeholder" label.
  5. The design lead presents the issue to the stakeholders at the stakeholder meeting.
    • If the stakeholders decide that updates need to be made to the proposed designs, one of the design leads will leave comments in the issue detailing those updates and will move the issue back to the In Progress column.
  6. If the stakeholders approve of the proposed designs, one of the design leads will remove the "Waiting for Stakeholder" label and leave a comment in the issue tagging the assignee and letting them know of the approval status along with any feedback the stakeholders or other team members had.
  7. In the Figma page, the assignee places the final designs in a red-bordered section that has the title "FINAL DESIGN".
  8. The assignee updates the design system in Figma with whichever part of the final designs are most relevant. If the assignee is unsure about how to format these changes, they can consult the design leads.
  9. The assignee updates any relevant Google Drive documents that are affected by their issue, such as the Design System Presentation or the list of modal design updates.
  10. In the GitHub issue, the assignee leaves a comment that includes images of the approved mockups along with any information about how it is intended to behave in the system, such as minimum and maximum widths and heights, hover states, what happens upon clicking an icon, etc.
  11. The assignee adds anyone who had previously worked on the issue as an assignee.
  12. The assignee closes the issue.
  13. The assignee creates a new development handoff issue that includes:
    • an Overview section that has the sentence "Please implement [brief summary of design] as detailed in [link to final design comment] via [design issue number]."
    • a Description section that has the same information that was listed in the final comment of the design issue
    • an Action Items section
    • a Resources section that includes:
      • steps to take on the TDM Dev site in order to locate where the designs should be implemented
      • links to relevant TDM Dev site pages
      • links to relevant GitHub issues
      • link to the Figma page of the related design issue
      • link to any related Figma design system page
      • link to any related Google Drive documents
  14. The assignee creates a slide on the Staging Deck for the development handoff issue.
Clone this wiki locally