Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide suggest buttons on Toolkit Page #3721

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

Skydodle
Copy link
Member

Fixes #3678

What changes did you make and why did you make them ?

  • Added the hidden attribute to buttons "Suggest a guide" and "Suggest a resource" because we currently do not have any functionality for those buttons yet
  • Added comment on each button to explain that the buttons would stay hidden until we figure out how we want the buttons to function later
  • Checked desktop, mobile, and tablet views to make sure both buttons no longer appear
  • Checked with a screen reader to make sure both buttons are not read

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

Screen Shot 2022-11-15 at 6 17 01 PM
Screen Shot 2022-11-15 at 6 17 13 PM

Visuals after changes are applied

Screen Shot 2022-11-15 at 6 19 00 PM
Screen Shot 2022-11-15 at 6 19 10 PM

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b Skydodle-hide-suggest-buttons-3678 gh-pages
git pull https://github.com/Skydodle/website.git hide-suggest-buttons-3678

@github-actions github-actions bot added P-Feature: Toolkit https://www.hackforla.org/toolkit/ role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours Complexity: Small Take this type of issues after the successful merge of your second good first issue labels Nov 15, 2022
@jyaymie jyaymie self-requested a review November 15, 2022 23:06
@jyaymie
Copy link
Member

jyaymie commented Nov 15, 2022

Review ETA: 11/15/22 5pm
Availability: 11/15/22 Flexible

Copy link
Member

@jyaymie jyaymie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've taken care of all action items in the linked issue, and your screenshots capture exactly what I saw during my own tests. (It never crossed my mind that there was a Chrome screen reader extension!) Great work, @Skydodle!

@plang-psm plang-psm self-requested a review November 16, 2022 00:20
@plang-psm
Copy link
Member

Review ETA: 11/20/22
Availability: 6 hrs

Copy link
Member

@plang-psm plang-psm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hidden attribute hides both buttons and the comments cover all basis. Good work!

@blulady blulady merged commit 429dfee into hackforla:gh-pages Nov 16, 2022
blulady added a commit that referenced this pull request Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Toolkit https://www.hackforla.org/toolkit/ role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
Development

Successfully merging this pull request may close these issues.

Toolkit page: Hide suggest buttons
4 participants