Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated project page filters to show tools #6549

Merged

Conversation

partapparam
Copy link
Member

@partapparam partapparam commented Mar 30, 2024

Fixes #6196

What changes did you make?

  • Added Tools into Languages/Technologies filter on the projects page, revising it to Languages/Technologies/Tools
  • Update projectCardComponent to include Tools in the file for frequency tracking
  • Refactored createFilter function so that Tools is added as a filter
  • Added tools into updateProjectCardDisplayState
  • Added tools to be tracked with technologies in the updateCategoryCounter

Why did you make the changes (we will use this info to test)?

  • Provide users with the ability to filter projects based on Tools.
  • Ensure that when a Tool is selected as a filter, it displays correctly as Tool: <tool-name>
  • Ensure that projects-check page does not change

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

image

image

Visuals after changes are applied Screenshot 2024-03-29 at 5 26 21 PM Screenshot 2024-04-01 at 7 44 01 PM Screenshot 2024-04-01 at 7 44 12 PM

image

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b partapparam-update-projects-page-filter-6196 gh-pages
git pull https://github.com/partapparam/website.git update-projects-page-filter-6196

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/partapparam/website/blob/update-projects-page-filter-6196/CONTRIBUTING.md  

@github-actions github-actions bot added role: front end Tasks for front end developers Complexity: Medium P-Feature: Projects page https://www.hackforla.org/projects/ size: 1pt Can be done in 4-6 hours labels Mar 30, 2024
@aadilahmed aadilahmed self-requested a review April 1, 2024 06:30
@aadilahmed
Copy link
Member

Review ETA: EOD 4/2/24
Availability: 9-5 PM Monday - Friday

@JackCasica JackCasica self-requested a review April 1, 2024 17:22
@JackCasica
Copy link
Member

Hi ~ I'll be reviewing this PR today ~
Availability: (04/01)
ETA: EOD (04/01)

Copy link
Member

@JackCasica JackCasica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @partapparam ~ In this PR you...

  • Consolidated Filter Category: The technologies filter category now includes languages, technologies, and tools. This consolidates these related items into a single filter, making it easier for users to find what they need. ✅

  • Updated Project Card Component: The projectCardComponent function has been updated to include all languages, technologies, and tools in the data-technologies attribute of the project card. This allows the updateFilterFrequency function to accurately calculate and display the frequency of each filter item across the visible project cards. ✅

I did notice that something in the filtering logic on line 233 is preventing "ArcGIS surveys" from showing up in the new consolitated filter list:
image

Additionally the badge component that shows up when a category is selected is no longer accurate if the changes requested in the issue are implemented.
image
"Technology: ArcGIS surveys" should be "Tool: ArcGIS surveys"

I believe this should be addressed as part of this issue, but you may want to move the the issue to Questions / In Review to get clarification as to whether this piece should be it's own future issue before working on it.

Copy link
Member Author

@partapparam partapparam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JackCasica thanks for the detailed feedback. It looks like there was a conflicting merge after my submission so I've updated the code to reflect the changes.

@partapparam partapparam requested a review from JackCasica April 2, 2024 17:08
Copy link
Member

@aadilahmed aadilahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filtering by tools works correctly on the project page, great job!

@partapparam
Copy link
Member Author

@JackCasica can you review the updated pull request? I believe I have made the changes you requested, though I'm unsure how to mark your change request as complete.

@JackCasica
Copy link
Member

@partapparam Looking at your changes locally, I see that the

  • ArcGIS surveys does in fact show up ✅
  • The badge text is accurate ✅
  • The projects-check page is unchanged per the issue requirements ✅
image

Nice job with everything! ~

@gaylem gaylem merged commit 1274bc5 into hackforla:gh-pages Apr 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium P-Feature: Projects page https://www.hackforla.org/projects/ role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Tools to the Languages/Technologies filter group on the projects page
4 participants