-
-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated project page filters to show tools #6549
updated project page filters to show tools #6549
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:
|
Review ETA: EOD 4/2/24 |
Hi ~ I'll be reviewing this PR today ~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @partapparam ~ In this PR you...
-
Consolidated Filter Category: The technologies filter category now includes languages, technologies, and tools. This consolidates these related items into a single filter, making it easier for users to find what they need. ✅
-
Updated Project Card Component: The projectCardComponent function has been updated to include all languages, technologies, and tools in the data-technologies attribute of the project card. This allows the updateFilterFrequency function to accurately calculate and display the frequency of each filter item across the visible project cards. ✅
I did notice that something in the filtering logic on line 233 is preventing "ArcGIS surveys" from showing up in the new consolitated filter list:
Additionally the badge component that shows up when a category is selected is no longer accurate if the changes requested in the issue are implemented.
"Technology: ArcGIS surveys" should be "Tool: ArcGIS surveys"
I believe this should be addressed as part of this issue, but you may want to move the the issue to Questions / In Review to get clarification as to whether this piece should be it's own future issue before working on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JackCasica thanks for the detailed feedback. It looks like there was a conflicting merge after my submission so I've updated the code to reflect the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Filtering by tools works correctly on the project page, great job!
@JackCasica can you review the updated pull request? I believe I have made the changes you requested, though I'm unsure how to mark your change request as complete. |
@partapparam Looking at your changes locally, I see that the
![]() Nice job with everything! ~ |
Fixes #6196
What changes did you make?
Tools
intoLanguages/Technologies
filter on the projects page, revising it toLanguages/Technologies/Tools
projectCardComponent
to include Tools in the file for frequency trackingcreateFilter
function so that Tools is added as a filtertools
into updateProjectCardDisplayStatetools
to be tracked with technologies in theupdateCategoryCounter
Why did you make the changes (we will use this info to test)?
Tool: <tool-name>
projects-check
page does not changeScreenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied