Add basic CI setup #84
Conversation
Unit tests are still failing for seemingly other reasons. Looking into them still.
| @@ -0,0 +1 @@ | |||
| python 3.9.17 | |||
There was a problem hiding this comment.
Added this since asdf is being used on https://github.com/hackgvl/slack-events-bot
| - name: Pylint | ||
| run: python -m pylint **/*.py | ||
|
|
||
| - name: Set Stage for Unit Tests |
There was a problem hiding this comment.
I would love to eliminate this step.
| - name: Black | ||
| run: python -m black --check src/ | ||
|
|
||
| - name: Pylint | ||
| run: python -m pylint **/*.py |
There was a problem hiding this comment.
These are in use on https://github.com/hackgvl/slack-events-bot. Do we want to enforce the same linting rules in this repository? I gave each a shot locally, and the diff would be quite large.
I think there would be a lot of value in having consistency across the org, though, so it may be worth it.
|
@ThorntonMatthewD there's better than not chance we move away from Python and integrate the events API into the Laravel stack. This is because we figure we can't trust that Meetup won't kill the current REST API since they have a newer GraphQL API and they removed the docs for the older REST version. So, I don't know that we want to put a lot of effort into this repo unless we determine to stay with Python. At least for now, it's good to know we have another experienced Python dev. Thanks |
|
Thank you for the heads up! I'll catch up on the discussions around the rewrite and standby. |
|
@all-contributors add @ThorntonMatthewD for tests, infra, research |
|
I've put up a pull request to add @ThorntonMatthewD! 🎉 |
|
@ThorntonMatthewD with the deploy of hackgvl/hackgreenville-com#186 we're heading away from this Python repo, but we've noted your contributions on the All Contributors. Thanks |
WIP
Feel free to hop in and join the fun!
Unit tests are still failing for seemingly other reasons, and I'm looking into them still.