Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Contribution Button and Some CSS Tweaks #31

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Add Contribution Button and Some CSS Tweaks #31

merged 2 commits into from
Oct 16, 2023

Conversation

ThorntonMatthewD
Copy link
Collaborator

@ThorntonMatthewD ThorntonMatthewD commented Oct 16, 2023 •
edited
Loading

Summary

  • A "Learn how to contribute!" button was added to the bottom nabvar
  • A CSS bug where the attribution control was cut off on the map was fixed.
  • All copy that read "Click here to..." had that portion removed.
  • Set the links in the attribution control be open new tabs whenever clicked.

Screenshots

Desktop

Screenshot_2023-10-16_19-30-24

Mobile

Screenshot_2023-10-16_19-30-47

Testing Plan

  1. The "Learn how to contribute!" button should appear at the bottom of all pages.
  2. The banner at the top of the page should read "Learn how to contribute" also.
  3. The attribution control should visible, and the links therein should open new tabs whenever clicked.
  4. The map should fill the entire space between the banner (or top of page if banner is absent) to the top of the navbar, and not overhang, at any screen size.

@ThorntonMatthewD
Add contribution button
34865fb 
Fix some CSS issues where the attribution control was hidden

Adjust some of the verbiage on the contribution buttons and links
@ThorntonMatthewD
Add a couple of target=_blanks
f6f1fce
@ThorntonMatthewD ThorntonMatthewD marked this pull request as ready for review October 16, 2023 23:33
@ThorntonMatthewD ThorntonMatthewD self-assigned this Oct 16, 2023
oliviasculley
oliviasculley approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@oliviasculley oliviasculley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!!

@oliviasculley oliviasculley merged commit 711a57a into hackgvl:develop Oct 16, 2023
1 check passed
@ThorntonMatthewD ThorntonMatthewD deleted the add-contribute-button-to-nav branch October 16, 2023 23:52
@ThorntonMatthewD ThorntonMatthewD restored the add-contribute-button-to-nav branch October 16, 2023 23:52
@ThorntonMatthewD ThorntonMatthewD deleted the add-contribute-button-to-nav branch October 16, 2023 23:52
@ThorntonMatthewD
Copy link
Collaborator Author

Looks great!!

Thank you so much for taking a look at this. I really appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviasculley oliviasculley oliviasculley approved these changes

Assignees

@ThorntonMatthewD ThorntonMatthewD

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThorntonMatthewD @oliviasculley