Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #32 #36

Merged
merged 2 commits into from
Oct 30, 2023
Merged

fixes #32 #36

merged 2 commits into from
Oct 30, 2023

Conversation

Alex-Grimes
Copy link
Member

updated the max zoom level for the current set of map tiles

@Alex-Grimes
Copy link
Member Author

fixes #32

ThorntonMatthewD
ThorntonMatthewD requested changes Oct 28, 2023
View reviewed changes
Copy link
Collaborator

@ThorntonMatthewD ThorntonMatthewD left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've validated the change you've made! It looks great! 😄

What do you think about writing a Cypress test for the new limit? This one could be a good template, where the deltaY for the scroll is set to something crazy like -66.666666 * 50, and there's a check to see that the url still only reports a zoom=18. This may be overkill, so please let me know if this feels kind of silly.

@Alex-Grimes
Copy link
Member Author

Yeah should be no problem haven't worked with cypress so should be fun

@ThorntonMatthewD
Copy link
Collaborator

Yeah should be no problem haven't worked with cypress so should be fun

Thank you! I hadn't used it before contributing to this project either, and it's pretty cool!

I'll be on standby to re-review and for any support.

@Alex-Grimes
Copy link
Member Author

Added in the e2e test to confirm 18 is the max zoom now

@ThorntonMatthewD ThorntonMatthewD force-pushed the issue-#32-max-zoom-change branch from 8faca06 to c33c9a3 Compare October 29, 2023 19:38
ThorntonMatthewD
ThorntonMatthewD approved these changes Oct 29, 2023
View reviewed changes
Copy link
Collaborator

@ThorntonMatthewD ThorntonMatthewD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! LGTM!!!

@ThorntonMatthewD
Copy link
Collaborator

@oliviasculley Is it okay for this PR to be merged?

@oliviasculley
Copy link
Member

Just FYI you're a maintainer now, so feel free 😄

@oliviasculley oliviasculley merged commit c0cf6d2 into hackgvl:develop Oct 30, 2023
1 check passed
@oliviasculley
Copy link
Member

@all-contributors add Alex-Grimes for code and tests

@allcontributors allcontributors bot mentioned this pull request Oct 30, 2023
Merged
@allcontributors
Copy link

@oliviasculley

I've put up a pull request to add @Alex-Grimes! 🎉

@ThorntonMatthewD ThorntonMatthewD mentioned this pull request Oct 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThorntonMatthewD ThorntonMatthewD ThorntonMatthewD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Alex-Grimes @ThorntonMatthewD @oliviasculley