fixes #29 #41
Merged
fixes #29 #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
full screen |
|
Found a intermittent issue in the e2e test for about where the click trigger was not actually happening really bizarre behavior honestly. Would consistently trigger and operate correctly with Dev tools open but not without them, Could also manually force the click that was supposed to be happening that was not on every run. added the Force option on the click and seems to behave more consistently now. |
oliviasculley
approved these changes
Nov 25, 2023
|
any chance of this getting merged in? |
|
@Alex-Grimes Yes! Sorry- I did not have notifications set up until recently on this repo. Thank you so much! |
|
@all-contributors add @Alex-Grimes for design and bugs :D |
|
I've put up a pull request to add @Alex-Grimes! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #29 created a 404 page and added catchall route