Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify CI #30

Merged
merged 2 commits into from
Sep 30, 2023
Merged

Simplify CI #30

merged 2 commits into from
Sep 30, 2023

Conversation

oliviasculley
Copy link
Member

@oliviasculley oliviasculley commented Sep 30, 2023 •
edited
Loading

  • This way we don't need to specify versions for each command, it'll just use the one that is set up
  • Also removes need to specify version number in branch protections
  • Microsoft action is a bit complicated and i am fickle
  • Renaming to test since it doesn't actually do any linting, just testing of linting and we may want a separate lint that will forcibly run linting or something
  • Also ran pipreqs --force, updated pyproject.toml

@oliviasculley oliviasculley self-assigned this Sep 30, 2023
@ThorntonMatthewD ThorntonMatthewD mentioned this pull request Sep 30, 2023
Closed
@oliviasculley oliviasculley force-pushed the improve-ci branch 5 times, most recently from ff187c7 to 645b540 Compare September 30, 2023 19:11
ThorntonMatthewD
ThorntonMatthewD approved these changes Sep 30, 2023
View reviewed changes
Copy link
Collaborator

@ThorntonMatthewD ThorntonMatthewD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic!! Thank you!

@oliviasculley oliviasculley merged commit 8762fad into dev Sep 30, 2023
1 check passed
@oliviasculley oliviasculley deleted the improve-ci branch September 30, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThorntonMatthewD ThorntonMatthewD ThorntonMatthewD approved these changes

Assignees

@oliviasculley oliviasculley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oliviasculley @ThorntonMatthewD