Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Coordinate Composition #51

Merged
merged 4 commits into from
Dec 7, 2023

Conversation

ThorntonMatthewD
Copy link
Collaborator

@ThorntonMatthewD ThorntonMatthewD commented Dec 7, 2023

Summary

Fixes a bug where coordinates for events were being composed by using the latitude twice instead of latitude and then longitude.

Before After
Screenshot_2023-12-07_13-23-08 Screenshot_2023-12-07_13-23-28

@ThorntonMatthewD ThorntonMatthewD marked this pull request as ready for review December 7, 2023 18:24
Copy link
Member

@oliviasculley oliviasculley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ready to go! I added one small suggestion, but with the inclusion of the test, this bug is squashed for good!

src/event.py Outdated Show resolved Hide resolved
Co-authored-by: Olivia Sculley <[email protected]>
@ThorntonMatthewD
Copy link
Collaborator Author

This looks ready to go! I added one small suggestion, but with the inclusion of the test, this bug is squashed for good!

Thank you, Olivia! I've committed your suggestion. I'm 100% on board with it.

@ThorntonMatthewD ThorntonMatthewD merged commit 56a9386 into hackgvl:dev Dec 7, 2023
1 check passed
@ThorntonMatthewD ThorntonMatthewD deleted the fix-coords branch December 7, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants