-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expr/disable worker #23
Merged
Merged
+431
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanley2058
force-pushed
the
expr/disable-worker
branch
from
January 22, 2025 07:23
2618d3a
to
da3e114
Compare
stanley2058
force-pushed
the
expr/disable-worker
branch
2 times, most recently
from
January 22, 2025 13:35
ad99461
to
adb38bd
Compare
stanley2058
force-pushed
the
expr/disable-worker
branch
from
January 23, 2025 04:11
adb38bd
to
b9d1882
Compare
Due to storage not being managed here, the worker is created externally and passed in. Thus, status handling should also be handled externally where the worker is created. |
Yukaii
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move worker duty into socket io server.
Pros:
Cons:
Others: