Feature - Run tests from many assemblies #423
Conversation
Expecto/Expecto.Impl.fs
Outdated
| /// Scan filtered tests marked with TestsAttribute from an assembly | ||
| let testFromAssemblyWithFilter typeFilter (assembly : Assembly) = | ||
| testListFromAssemblyWithFilter typeFilter assembly | ||
| |> listToTestListOption |
There was a problem hiding this comment.
This looks like it just changed the return type of the function testFromAssemblyWithFilter from a list to whatever listToTestListOption returns?
There was a problem hiding this comment.
True, we could probably compose those functions together instead. 👍
Completed!
There was a problem hiding this comment.
My point here is that you've changed a public ABI, by currying instead of providing explicit parameters. Could you explicitly declare and pass the parameters please to avoid this change? (Eta expansion) Thank you
|
Is this ready to merge? |
Sure is! |
| @@ -618,6 +618,15 @@ module Tests = | |||
| let tests = testFromThisAssembly() |> Option.orDefault (TestList ([], Normal)) | |||
| runTestsWithArgsAndCancel ct config args tests | |||
|
|
|||
| /// Runs tests in the specified assemblies with the supplied command-line options. | |||
| /// Returns 0 if all tests passed, otherwise 1 | |||
| let runTestsInAssembliesWithCLIArgsAndCancel (ct:CancellationToken) cliArgs args assemblies = | |||
There was a problem hiding this comment.
This is mostly a style-related comment. 😜
The other functions are written as let foo (bar : baz) = .... Should this one follow the same style?
When there are multiple assemblies of tests for an FSharp project, it is a pain to run each project of tests individually using the
dotnetcli.I think it's valuable to use the
dotnet watchtooling as well which doesn't work as nicely with multiple test projects either.This PR adds the ability to specify multiple assemblies from the test runner in the
Main.fsfile when callingrunTestsInAssembly.That way all the results show up in one big list and we can use useful tooling like
dotnet watchon a single project.