Added runTests to simplify usage in interactive mode #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In interactive mode, it is superfluous to give default empty parameters. Thus I propose runTests
|
This is something that caused me to double take when I first started with the library. I feel like this is a fairly high-traffic API decision though, and @haf should have the final call. |
|
I think it sounds like a great change! |
farlee2121
reviewed
Feb 13, 2024
| testCase "A simple test" <| fun () -> | ||
| Expect.equal 4 (2+2) "2+2 = 4" | ||
|
|
||
| runTestsWithCLIArgs [] [||] simpleTest |
There was a problem hiding this comment.
@sporring Could you clarify the motivation of these fsx files?
farlee2121
reviewed
Feb 13, 2024
| @@ -633,6 +633,10 @@ module Tests = | |||
| let runTestsWithCLIArgs cliArgs args tests = | |||
| runTestsWithCLIArgsAndCancel CancellationToken.None cliArgs args tests | |||
|
|
|||
| /// Runs all given tests. | |||
| /// Returns 0 if all tests passed, otherwise 1 | |||
| let runTests = runTestsWithCLIArgs [] [||] | |||
There was a problem hiding this comment.
We should also document this in the ReadMe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In interactive mode, it is superfluous to give default empty parameters. Thus I propose runTests