code refactor

haiwen · Jan 26, 2018 · d53a276 · d53a276
1 parent c8ff3d1
commit d53a276
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 8 deletions.
diff --git a/Pod/Classes/SeafTaskQueue.m b/Pod/Classes/SeafTaskQueue.m
@@ -43,8 +43,8 @@ - (instancetype)init {
             Debug("finish task %@, %ld tasks remained.",task.name, (long)[weakSelf taskNumber]);
             task.lastFinishTimestamp = [[NSDate new] timeIntervalSince1970];
             if (!result) { // Task fail, add to the tail of queue for retry
-                strongSelf.failedCount += 1;
                 @synchronized (strongSelf.tasks) {
+                    strongSelf.failedCount += 1;
                     if (task.retryable) {
                         task.retryCount += 1;
                         [strongSelf.tasks addObject:task];

diff --git a/seafile/SeafAppDelegate.m b/seafile/SeafAppDelegate.m
@@ -102,9 +102,10 @@ - (void)enterAccount:(SeafConnection *)conn
             [self.tabbarController setViewControllers:vcs];
         }
     }
-    if (updated)
+    if (updated) {
         [SeafDataTaskManager.sharedObject startLastTimeUnfinshTaskWithConnection:conn];
         [self.tabbarController setSelectedIndex:TABBED_SEAFILE];
+    }
     self.window.rootViewController = self.tabbarController;
     [self.window makeKeyAndVisible];
 

diff --git a/seafile/SeafSettingsViewController.m b/seafile/SeafSettingsViewController.m
@@ -397,6 +397,13 @@ - (void)viewDidLoad
     _version = [infoDictionary objectForKey:@"CFBundleShortVersionString"];
     _versionCell.detailTextLabel.text = _version;
     [self configureView];
+
+    SeafDataTaskManager.sharedObject.trySyncBlock = ^(id<SeafTask>  _Nonnull task) {
+        [self performSelectorInBackground:@selector(updateSyncInfo) withObject:nil];
+    };
+    SeafDataTaskManager.sharedObject.finishBlock = ^(id<SeafTask>  _Nonnull task) {
+        [self performSelectorInBackground:@selector(updateSyncInfo) withObject:nil];
+    };
 }
 
 - (void)viewDidAppear:(BOOL)animated
@@ -464,12 +471,6 @@ - (void)configureView
     _serverCell.detailTextLabel.text = [_connection.address trimUrl];
 
     [self updateSyncInfo];
-    SeafDataTaskManager.sharedObject.trySyncBlock = ^(id<SeafTask>  _Nonnull task) {
-        [self performSelectorInBackground:@selector(updateSyncInfo) withObject:nil];
-    };
-    SeafDataTaskManager.sharedObject.finishBlock = ^(id<SeafTask>  _Nonnull task) {
-        [self performSelectorInBackground:@selector(updateSyncInfo) withObject:nil];
-    };
 
     [self.tableView reloadData];
 }