-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wiki share #6341
Add wiki share #6341
Conversation
39c2717
to
bc57b0d
Compare
seahub/api2/endpoints/wiki2.py
Outdated
filter_repo_ids = [] | ||
filter_repo_type_ids = {} | ||
if filter_by['mine']: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
filter_repo_type_ids 是一个映射, 命名改成 filter_repo_type_ids_map
seahub/wiki2/views.py
Outdated
@@ -34,7 +34,6 @@ def wiki_view(request, wiki_id): | |||
""" | |||
# get wiki object or 404 | |||
wiki = get_object_or_404(Wiki, id=wiki_id) | |||
|
|||
page_id = request.GET.get('page_id') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
去掉这个改动
seahub/api2/endpoints/wiki2.py
Outdated
group_info['repos'] = repos | ||
if len(group_repos) == 0: | ||
group_info['repos'] = repos | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if len(group_repos)==0 不需要判断
seahub/api2/endpoints/wiki2.py
Outdated
"repo_name": r.name, | ||
} | ||
repos.append(repo) | ||
group_info['repos'] = repos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个写在for循环外面, 先 append 完了之后, 在装入字典
update leave and return
No description provided.