Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wiki share #6341

Closed
wants to merge 10 commits into from
Closed

Add wiki share #6341

wants to merge 10 commits into from

Conversation

awu0403
Copy link
Contributor

@awu0403 awu0403 commented Jul 12, 2024

No description provided.

@awu0403 awu0403 force-pushed the add-wiki-share branch 2 times, most recently from 39c2717 to bc57b0d Compare July 15, 2024 15:44
filter_repo_ids = []
filter_repo_type_ids = {}
if filter_by['mine']:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

filter_repo_type_ids 是一个映射, 命名改成 filter_repo_type_ids_map

@@ -34,7 +34,6 @@ def wiki_view(request, wiki_id):
"""
# get wiki object or 404
wiki = get_object_or_404(Wiki, id=wiki_id)

page_id = request.GET.get('page_id')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

去掉这个改动

group_info['repos'] = repos
if len(group_repos) == 0:
group_info['repos'] = repos

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if len(group_repos)==0 不需要判断

"repo_name": r.name,
}
repos.append(repo)
group_info['repos'] = repos
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个写在for循环外面, 先 append 完了之后, 在装入字典

update leave and return
@freeplant freeplant deleted the branch 12.0 July 24, 2024 06:18
@freeplant freeplant closed this Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants