-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add context menu on metadata #6504
Conversation
f170e94
to
009f721
Compare
@@ -605,6 +600,8 @@ RecordsBody.propTypes = { | |||
getCopiedRecordsAndColumnsFromRange: PropTypes.func, | |||
openDownloadFilesDialog: PropTypes.func, | |||
cacheDownloadFilesProps: PropTypes.func, | |||
onRowExpand: PropTypes.func, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rowExpand 功能已经取消! 这个props 没有必要了
return ( | ||
<ul | ||
ref={menuRef} | ||
className='context-menu' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
对于metadata项目, className 添加sf-metadata前缀, 防止 css 污染(限制作用域)。
@@ -83,6 +83,7 @@ class ContextMenu extends React.Component { | |||
handleShow = (e) => { | |||
if (e.detail.id !== this.props.id) return; | |||
const { x, y } = e.detail.position; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
无关的修改建议恢复代码原样。
frontend/src/metadata/metadata-view/components/context-menu/context-menu.jsx
Outdated
Show resolved
Hide resolved
* fix: set width fail * feat: update code * feat: update code * feat: update code * feat: update code --------- Co-authored-by: 杨国璇 <[email protected]>
fix: selected file metadata info
Co-authored-by: 杨国璇 <[email protected]>
No description provided.