Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context menu on metadata #6504

Closed
wants to merge 20 commits into from
Closed

Conversation

Aries-0331
Copy link
Contributor

No description provided.

@Aries-0331 Aries-0331 force-pushed the add_context_menu_on_metadata branch from f170e94 to 009f721 Compare August 7, 2024 14:32
@@ -605,6 +600,8 @@ RecordsBody.propTypes = {
getCopiedRecordsAndColumnsFromRange: PropTypes.func,
openDownloadFilesDialog: PropTypes.func,
cacheDownloadFilesProps: PropTypes.func,
onRowExpand: PropTypes.func,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rowExpand 功能已经取消! 这个props 没有必要了

return (
<ul
ref={menuRef}
className='context-menu'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

对于metadata项目, className 添加sf-metadata前缀, 防止 css 污染(限制作用域)。

@@ -83,6 +83,7 @@ class ContextMenu extends React.Component {
handleShow = (e) => {
if (e.detail.id !== this.props.id) return;
const { x, y } = e.detail.position;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

无关的修改建议恢复代码原样。

@haiwen haiwen deleted a comment from YangGuoXuan-0503 Aug 8, 2024
@haiwen haiwen deleted a comment from YangGuoXuan-0503 Aug 8, 2024
@Aries-0331 Aries-0331 closed this Aug 9, 2024
@freeplant freeplant deleted the add_context_menu_on_metadata branch February 15, 2025 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants