Lock notification #7026
Open
Lock notification #7026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r350178982
reviewed
Nov 20, 2024
| class WebSocketService { | ||
| constructor(onMessageCallback, repoId) { | ||
|
|
||
| this.url = 'ws://localhost:8083'; // WebSocket address; |
There was a problem hiding this comment.
url不要在这里写死， 写到seahub_settings里面然后，通过html中继器来读取
r350178982
reviewed
Nov 20, 2024
| @@ -146,8 +146,40 @@ class LibContentView extends React.Component { | |||
| componentDidMount() { | |||
| this.unsubscribeEvent = this.props.eventBus.subscribe(EVENT_BUS_TYPE.SEARCH_LIBRARY_CONTENT, this.onSearchedClick); | |||
| this.calculatePara(this.props); | |||
| this.socket = new WebSocketService(this.onMessageCallback, this.props.repoID); | |||
r350178982
reviewed
Nov 20, 2024
| @@ -0,0 +1,101 @@ | |||
| import { userAPI } from '../utils/user-api'; | |||
There was a problem hiding this comment.
文件名改成 listen-notification --> websocket-service.js
r350178982
reviewed
Nov 20, 2024
|
|
||
| handleMessage(data) { | ||
| switch (data.type) { | ||
| case 'file-lock-changed': |
There was a problem hiding this comment.
这里不需要用case的吧， 在回调处进行判断就可以了。 websocke-service层面这里不需要知道具体的数据类型(尽量与seafile中的业务数据分离)。 接受到消息，把数据传递给回调函数， 然后在调用函数的外部组件中去扩展就可以了
r350178982
reviewed
Nov 20, 2024
| } | ||
|
|
||
| close() { | ||
| this.shouldReconnect = false; |
There was a problem hiding this comment.
这里需要发送请求来unsubscribe这个repo
r350178982
reviewed
Nov 21, 2024
| this.url = 'ws://localhost:8083'; // WebSocket address; | ||
| this.repoId = repoId; | ||
| this.socket = null; | ||
| this.heartbeatInterval = null; |
There was a problem hiding this comment.
这里heartbetInterval好像没用到， 看看是不是可以删掉
r350178982
force-pushed
the
lock-notification
branch
from
2b07e94 to
c671f8a
Compare
awu0403
force-pushed
the
lock-notification
branch
2 times, most recently
from
63acdd5 to
a276945
Compare
awu0403
force-pushed
the
lock-notification
branch
from
a276945 to
e185985
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.