add delete button to image previwer in gallery #7170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -340,6 +342,31 @@ const Main = ({ isLoadingMore, metadata, onDelete, onLoadMore }) => { | |||
| } | |||
| }, [handleImageSelection, updateSelectedImage]); | |||
|
|
|||
| const deleteImage = useCallback((name) => { | |||
| const image = selectedImages.find(image => image.name === name); | |||
There was a problem hiding this comment.
image 重名时，这里对image 的定位不准确，因此会删除错误
Aries-0331
force-pushed
the
feature/add_delete_button_to_gallery_previewer
branch
from
4460949 to
0f02e9f
Compare
| @@ -30,6 +30,7 @@ class ImageDialog extends React.Component { | |||
| const imageItemsLength = imageItems.length; | |||
| if (imageItemsLength === 0) return null; | |||
| const name = imageItems[imageIndex].name; | |||
| const id = imageItems[imageIndex].id; | |||
There was a problem hiding this comment.
不是所有的image都会有这个id，这里应该返回一个image， 由调用这个组件库的父组件去处理，或者父组件不通过这个组件也可以知道当前 image (selectedImages[selectedImageIndex]), 可以参考PR https://github.com/haiwen/seahub/pull/6670/files#diff-814435c30c57e3cb88610310c6bbc38456c6618a7802987de27926dc07c18e15R297 自己写的这部分代码。
Aries-0331
force-pushed
the
feature/add_delete_button_to_gallery_previewer
branch
from
0f02e9f to
6d51a79
Compare
| setIsImagePopupOpen(false); | ||
| setImageIndex(0); | ||
| } else { | ||
| const newIndex = Math.min(index, newImageItems.length - 1); |
There was a problem hiding this comment.
对于删除最后一张，这里有点问题：删除的是最后一张，需要转到第一张(和其他地方的交互保持一致)，而不是上一张吧。
Aries-0331
force-pushed
the
feature/add_delete_button_to_gallery_previewer
branch
from
da088eb to
c6313a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.