Feature/filter by tags #7242
Merged
Feature/filter by tags #7242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aries-0331
force-pushed
the
feature/filter_by_tags
branch
from
1f99714 to
6902a37
Compare
frontend/src/metadata/components/popover/filter-popover/advanced-filters/filter-item/index.js
Outdated
Show resolved
Hide resolved
frontend/src/metadata/components/cell-editors/editor-container/index.js
Outdated
Show resolved
Hide resolved
...etadata/components/popover/filter-popover/advanced-filters/filter-item/tags-filter/index.css
Outdated
Show resolved
Hide resolved
Aries-0331
force-pushed
the
feature/filter_by_tags
branch
from
2ba8213 to
74d3f04
Compare
seahub/repo_metadata/apis.py
Outdated
| @@ -1736,6 +1736,14 @@ def delete(self, request, repo_id): | |||
| error_msg = 'Internal Server Error' | |||
| return api_error(status.HTTP_500_INTERNAL_SERVER_ERROR, error_msg) | |||
|
|
|||
| # Remove _tags conditions from all table views | |||
| try: | |||
| RepoMetadataViews.objects.remove_tags_filter_conditions(repo_id) | |||
There was a problem hiding this comment.
不需要删除， 前端对于已经删除的列，处理过了， 构造sql 对于删除的列， 也处理过了。 a 关闭了tag， b正在编辑， 此时还是可以保存到 数据库的， 所以删除没有意义
YangGuoXuan-0503
force-pushed
the
feature/filter_by_tags
branch
from
b4296f6 to
0d30a5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.