Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crossplane helm #305

Merged
merged 59 commits into from
May 9, 2023
Merged

Crossplane helm #305

merged 59 commits into from
May 9, 2023

Conversation

cmoulliard
Copy link
Contributor

@cmoulliard cmoulliard commented Apr 25, 2023 •
edited
Loading

@cmoulliard cmoulliard mentioned this pull request May 4, 2023
Closed
cmoulliard added 11 commits May 4, 2023 09:27
@cmoulliard @aureamunoz
Adding the crossplane helm release CRD to the list of the urls to be …
4979cb7 
…converted to java classes

Signed-off-by: Charles Moulliard <[email protected]>
@cmoulliard @aureamunoz
Create a release-postgresql.yml to install the postgresql Helm chart.…
2157856 
… Updating the documentation of crossplane.md

Signed-off-by: Charles Moulliard <[email protected]>
@cmoulliard @aureamunoz
WIP. Add a methof to generate the crossplane Release
95e8033 
Signed-off-by: Charles Moulliard <[email protected]>
@cmoulliard @aureamunoz
WIP. Instantiate the different builders needed
6126442 
Signed-off-by: Charles Moulliard <[email protected]>
@cmoulliard @aureamunoz
WIP. Top be improved as code looks horrible suing builders
997ba7e 
Signed-off-by: Charles Moulliard <[email protected]>
@cmoulliard @aureamunoz
Refactored the code of the Crossplane Release Builder
0537c84 
Signed-off-by: Charles Moulliard <[email protected]>
@cmoulliard @aureamunoz
Format the code. change the name of the Services from Register to Ser…
975fb11 
…vices catalog. Set the missing properties

Signed-off-by: Charles Moulliard <[email protected]>
@cmoulliard @aureamunoz
Reviewed the wording of the home page
9192044 
Signed-off-by: Charles Moulliard <[email protected]>
@cmoulliard @aureamunoz
WIP. Adding a second column to the form. Still have issue with the fi…
4a34358 
…elds validation

Signed-off-by: Charles Moulliard <[email protected]>
@cmoulliard @aureamunoz
Added missing fields of the ServiceRequest form
48ecbce 
Signed-off-by: Charles Moulliard <[email protected]>
@cmoulliard @aureamunoz
Rename <div to <form to fix the issue. Fix #309
3e938c5 
Signed-off-by: Charles Moulliard <[email protected]>
cmoulliard and others added 15 commits May 4, 2023 09:46
@cmoulliard
Add a TODO about how to get for a Service the cluster object which is…
acf2583 
… needed to create the kubernetesClient

Signed-off-by: Charles Moulliard <[email protected]>
@cmoulliard
Implementing the call to the method to deploy the service if installa…
c7558bb 
…ble is true. To be tested with crossplane

Signed-off-by: Charles Moulliard <[email protected]>
@cmoulliard
Including the source generated dir
a97051e 
Signed-off-by: Charles Moulliard <[email protected]>
@cmoulliard
Add usage to primaza.sh script. Removing the function to install kind…
5f9c88b 
…. Remove the hardcoded registry name

Signed-off-by: Charles Moulliard <[email protected]>
@cmoulliard
Updating the instructions to install crossplane
65c1dbc 
Signed-off-by: Charles Moulliard <[email protected]>
@cmoulliard
Reformat the exception
56ac5b3 
Signed-off-by: Charles Moulliard <[email protected]>
@cmoulliard
Removing non needed module
04e9165 
Signed-off-by: Charles Moulliard <[email protected]>
@cmoulliard
Removing the 2 builder classes that we dont use anymore
dc5aaf8 
Signed-off-by: Charles Moulliard <[email protected]>
@aureamunoz
remove not needed
acf0acd
@cmoulliard
Rename usage to primazaUsage
137000e 
Signed-off-by: Charles Moulliard <[email protected]>
@cmoulliard
Renamed the label from installable to To be provisioned. Fix some err…
63cb96e 
…ors with primaza script and update README

Signed-off-by: Charles Moulliard <[email protected]>
@cmoulliard
Change the column size from 2 to 5
29b0bb4 
Signed-off-by: Charles Moulliard <[email protected]>
@cmoulliard
Deploy atomic fruits using its helm chart
a8a75eb
@cmoulliard
Add the non neded namespace. Pass the env vars to configure the VAUKT…
8f42770 
… URL for localdeploy

Signed-off-by: Charles Moulliard <[email protected]>
@cmoulliard
Set the Release Chart fields using the Service object
1c57327 
Signed-off-by: Charles Moulliard <[email protected]>
@cmoulliard cmoulliard mentioned this pull request May 4, 2023
Closed
cmoulliard added 26 commits May 5, 2023 11:32
@cmoulliard
Updated the script to also install the kubernetes provider
94c05ab 
Signed-off-by: Charles Moulliard <[email protected]>
@cmoulliard
Renaming the name from postgresql-db to postgresql
870731f 
Signed-off-by: Charles Moulliard <[email protected]>
@cmoulliard
Removing the Kubernetest providerconfig as this is not needed
4236c44 
Signed-off-by: Charles Moulliard <[email protected]>
@cmoulliard
Renaming the resource from password to secret like also the providerC…
68f033b 
…onfigref of kubernetes as non needed
@cmoulliard
Still no luck to base64 the fields
b2fe35d 
Signed-off-by: Charles Moulliard <[email protected]>
@cmoulliard
Set the value to selected if the service.installable is true
001d8bc 
Signed-off-by: Charles Moulliard <[email protected]>
@cmoulliard
Fixing the issue as the boolean of the request was not saved due to u…
056f16e 
…ncorrect type used: boolan -> string

Signed-off-by: Charles Moulliard <[email protected]>
@cmoulliard
Added helm information to the service to be deployed
c96cb39 
Signed-off-by: Charles Moulliard <[email protected]>
@cmoulliard
Adding the missing space
0b4efdd 
Signed-off-by: Charles Moulliard <[email protected]>
@cmoulliard
Add new namespaces to be excluded by default for the cluster
80c3cc0 
Signed-off-by: Charles Moulliard <[email protected]>
@cmoulliard
Moving the code before to test if service is null, passing th namespa…
9f08c7b 
…ce which is required to the Helm Release CR

Signed-off-by: Charles Moulliard <[email protected]>
@cmoulliard
Removing the command to install the DB as we will provision it using …
571e0a4 
…crossplane. Disable the quarkus fruits helm chart to install also th DB.
@cmoulliard
Use the cluster coming from the Service or Application
e2722ba
@cmoulliard
Remove the step to upload to kind the docker image as it is uploaded …
09ba4d0 
…to the docker registry

Signed-off-by: Charles Moulliard <[email protected]>
@cmoulliard
Adding more logging as binding is failing as url is null !
75b801c
@cmoulliard
Fixing with hard coded valued the binding
ab9bc95 
Signed-off-by: Charles Moulliard <[email protected]>
@cmoulliard
Use the same chart version as tested whn we install manually the chart
2a7846e 
Signed-off-by: Charles Moulliard <[email protected]>
@cmoulliard
Increase vault slep time to let vault to be started. Implement the co…
c437efc 
…de to delete the Relasewhen we unbind. Fix the issue as the Helm chart values were not set properly. Rename the tile of the claim UI

Signed-off-by: Charles Moulliard <[email protected]>
@cmoulliard
Review the wording about the service available
ef2518e 
Signed-off-by: Charles Moulliard <[email protected]>
@cmoulliard
Updatd the code to support to create a claim before to claim and to u…
55933ce 
…se the modal window

Signed-off-by: Charles Moulliard <[email protected]>
@cmoulliard
Add if check to delete the Release only if the service installable is…
8befbf7 
… true. Be more verbose about what we log to scan/find services. Test within the listDiscoveredTable.html if the service.cluster exists like service.cluster.name

Signed-off-by: Charles Moulliard <[email protected]>
@cmoulliard
Creating a new class to collect the discovered services
bc4065c 
Signed-off-by: Charles Moulliard <[email protected]>
@cmoulliard
Fixing wrong findAll call
1765168 
Signed-off-by: Charles Moulliard <[email protected]>
@cmoulliard
Mapping the kubernetes svc discovered withlistdiscoveredTable - HTML
c7733ab 
Signed-off-by: Charles Moulliard <[email protected]>
@cmoulliard
Add a test to chck if claim.service.installable is not null
f1992e7 
Signed-off-by: Charles Moulliard <[email protected]>
@cmoulliard
Reformat the code
2867e56 
Signed-off-by: Charles Moulliard <[email protected]>
@cmoulliard cmoulliard marked this pull request as ready for review May 8, 2023 16:16
@cmoulliard cmoulliard mentioned this pull request May 8, 2023
Closed
@cmoulliard
Copy link
Contributor Author

cmoulliard commented May 9, 2023 •
edited
Loading

I will merge this PR as we can claim a service using either a service discovered and installed manually or automated (= crossplane). The tests are failing but as we must refactor and improve the logic which is not following the flow described here #313 we will fix them in a 2nd or 3rd review iteration post merging on main branch. @aureamunoz @Sgitario

@cmoulliard cmoulliard merged commit 1a75023 into main May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmoulliard @aureamunoz