Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue-403 #404

Merged
merged 21 commits into from
Sep 27, 2023
Merged

Issue-403 #404

merged 21 commits into from
Sep 27, 2023

Conversation

cmoulliard
Copy link
Contributor

@cmoulliard cmoulliard marked this pull request as ready for review September 26, 2023 12:16
@cmoulliard @aureamunoz
WIP. Adding a new field: type to display or hidesome fields
1767bc4 
Signed-off-by: Charles Moulliard <[email protected]>
@cmoulliard @aureamunoz
WIP. Add a note to specify that a new test case is needed. #403
cbcff11 
Signed-off-by: cmoulliard <[email protected]>
@cmoulliard @aureamunoz
Add a new JS function able to collapse (or not) the fields according …
f78ad26 
…to the type: basic or vault

Signed-off-by: cmoulliard <[email protected]>
@cmoulliard @aureamunoz
Adding the missing new parameter credential_type
8461247 
Signed-off-by: cmoulliard <[email protected]>
@cmoulliard @aureamunoz
Adding the missing field: credentialType to the createCredential method
61694ab 
Signed-off-by: cmoulliard <[email protected]>
@cmoulliard @aureamunoz
Format the code
a3a3cb8 
Signed-off-by: cmoulliard <[email protected]>
@cmoulliard @aureamunoz
Passing the needed parameter: credentialType to the createCredential …
d1d9f41 
…method

Signed-off-by: cmoulliard <[email protected]>
aureamunoz
aureamunoz requested changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@aureamunoz aureamunoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a minor renaming propal LGTM

app/src/test/java/io/halkyon/CredentialsPageTest.java Outdated Show resolved Hide resolved
aureamunoz
aureamunoz approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@aureamunoz aureamunoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aureamunoz aureamunoz merged commit 9116132 into main Sep 27, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aureamunoz aureamunoz aureamunoz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmoulliard @aureamunoz