Code

Api rework#34

Code

Merged

halleysfifthinc merged 64 commits intohalleysfifthinc:masterhalleysfifthinc/Peaks.jl:masterfrom KronosTheLate:api_reworkKronosTheLate/Peaks.jl:api_reworkCopy head branch name to clipboardFeb 28, 2024

+648-198

Commits

Commits on Sep 14, 2023

• Ignore autogenerated .vscode folder

  KronosTheLate

  committed
  baa439e

  Copy full SHA for baa439e

• Make parent file for rework, define "findpeaks"

  KronosTheLate

  committed
  d235238

  Copy full SHA for d235238

• implement api_rework as discussed

  KronosTheLate

  committed
  ccb918e

  Copy full SHA for ccb918e

• Remove test code from Peaks.jl

  KronosTheLate

  committed
  5cb66c3

  Copy full SHA for 5cb66c3

• Update readme to temp state

  KronosTheLate

  committed
  80b8280

  Copy full SHA for 80b8280

• Add sentence about mutation to todo section

  KronosTheLate

  committed
  7609635

  Copy full SHA for 7609635

• add sentence about minima finding

  KronosTheLate

  committed
  24e3892

  Copy full SHA for 24e3892

Commits on Sep 22, 2023

• Remove temporary content from readme

  KronosTheLate

  committed
  aac8d5a

  Copy full SHA for aac8d5a

Commits on Sep 24, 2023

• make findpeaks a oneliner

  KronosTheLate

  committed
  9ccd30a

  Copy full SHA for 9ccd30a

Commits on Sep 27, 2023

• Don't discard initially calculated heights

  KronosTheLate

  committed
  4a0d9dc

  Copy full SHA for 4a0d9dc

• Export filterpeaks, improve internals in new API

  KronosTheLate

  committed
  0e20f16

  Copy full SHA for 0e20f16

• Change linebreaks in "filterpeaks!"

  KronosTheLate

  committed
  369c072

  Copy full SHA for 369c072

• Make use of "strict" in all functions

  KronosTheLate

  committed
  080e970

  Copy full SHA for 080e970

• Fix some bugs

  KronosTheLate

  committed
  37839c8

  Copy full SHA for 37839c8

Commits on Oct 31, 2023

• export old functions

  KronosTheLate

  committed
  6edefcf

  Copy full SHA for 6edefcf

• improvements, polish docstrings

  KronosTheLate

  committed
  169e5dd

  Copy full SHA for 169e5dd

• tag breaking version

  KronosTheLate

  committed
  67cea1b

  Copy full SHA for 67cea1b

• misc changes

  KronosTheLate

  committed
  310fbfe

  Copy full SHA for 310fbfe

• comment out bad test

  KronosTheLate

  committed
  82c5b8e

  Copy full SHA for 82c5b8e

• minor changes

  KronosTheLate

  committed
  639f212

  Copy full SHA for 639f212

• fix docstrung for peakheights

  KronosTheLate

  committed
  8690fe2

  Copy full SHA for 8690fe2

Commits on Nov 26, 2023

• un-commented failing test

  KronosTheLate

  committed
  40ad1a7

  Copy full SHA for 40ad1a7

• revert exports

  KronosTheLate

  committed
  cf0d8c3

  Copy full SHA for cf0d8c3

• move export of filterpeaks!

  KronosTheLate

  committed
  3c17d0c

  Copy full SHA for 3c17d0c

• remove extra exports

  KronosTheLate

  committed
  21312b9

  Copy full SHA for 21312b9

• explicit about copying data in docstring

  KronosTheLate

  committed
  7f005f6

  Copy full SHA for 7f005f6

• Turn --> info ->

  KronosTheLate

  committed
  11eb80d

  Copy full SHA for 11eb80d

• add sentence about not copying data

  KronosTheLate

  committed
  df8537b

  Copy full SHA for df8537b

• minheight -> min, same for proms,widths, and max

  KronosTheLate

  committed
  5c82230

  Copy full SHA for 5c82230

• some changes + better length check in filterpeaks!

  KronosTheLate

  committed
  779081e

  Copy full SHA for 779081e

• add new method for filterpeaks!

  KronosTheLate

  committed
  c19d483

  Copy full SHA for c19d483

• Distribute contents of rework, structure exports

  KronosTheLate

  committed
  26cdb9d

  Copy full SHA for 26cdb9d

• Do not include api_work, which does not exist

  KronosTheLate

  committed
  c1d553d

  Copy full SHA for c1d553d

• fixed a couple copy-paste errors

  KronosTheLate

  committed
  676a0b5

  Copy full SHA for 676a0b5

Commits on Jan 22, 2024

• Revert function reordering (clarify changes in docstrings)

  halleysfifthinc

  committed
  b70804b

  Copy full SHA for b70804b

Commits on Jan 23, 2024

• Example compromise docstrings and ordering

  halleysfifthinc

  committed
  f9ab0f2

  Copy full SHA for f9ab0f2

• Revert random change (fixes tests)

  halleysfifthinc

  committed
  75a588e

  Copy full SHA for 75a588e

Commits on Jan 25, 2024

• Separate docstring examples for APIs

  KronosTheLate

  committed
  32b16e3

  Copy full SHA for 32b16e3

• Improve curried docstring

  KronosTheLate

  committed
  e98362d

  Copy full SHA for e98362d

• make known_fields a const

  KronosTheLate

  committed
  aaf8b51

  Copy full SHA for aaf8b51

• explain what a named tuple slice is

  KronosTheLate

  committed
  613d0f0

  Copy full SHA for 613d0f0

• Make filterpeaks signature match

  KronosTheLate

  committed
  8ac658d

  Copy full SHA for 8ac658d

• swap check order filterpeaks!

  KronosTheLate

  committed
  9848205

  Copy full SHA for 9848205

• Swap check order filterpeaks!

  KronosTheLate

  committed
  42aba3c

  Copy full SHA for 42aba3c

Commits on Feb 26, 2024

• Merge branch 'master' into api_rework

  halleysfifthinc

  committed
  83c53cb

  Copy full SHA for 83c53cb

Commits on Feb 28, 2024

• [nfc] whitespace changes

  halleysfifthinc

  committed
  36b71c7

  Copy full SHA for 36b71c7

• Update/rewrite docstrings and doctests

  halleysfifthinc

  committed
  df11d3a

  Copy full SHA for df11d3a

• Don't need to depwarn old kwargs for new functions

  halleysfifthinc

  committed
  bd468cc

  Copy full SHA for bd468cc

• Rename up => hi

  halleysfifthinc

  committed
  40ea9a3

  Copy full SHA for 40ea9a3

• Update peakproms!/peakwidths! to use ismaxima/isminima for argument validation

  halleysfifthinc

  committed
  9b7da88

  Copy full SHA for 9b7da88

• Rewrite error for bad min/max order

  halleysfifthinc

  committed
  5493b52

  Copy full SHA for 5493b52

• Fix unnecessary Missing union when input array doesn't have missings

  halleysfifthinc

  committed
  598477c

  Copy full SHA for 598477c

• Update doctest outputs

  halleysfifthinc

  committed
  d5b4281

  Copy full SHA for d5b4281

• Update deprecated kwargs in tests

  halleysfifthinc

  committed
  d805b04

  Copy full SHA for d805b04

• Test doctests when running tests

  halleysfifthinc

  committed
  5c98dab

  Copy full SHA for 5c98dab

• Test depwarns

  halleysfifthinc

  committed
  e791292

  Copy full SHA for e791292

• Test error for when first peak is not an extrema

  halleysfifthinc

  committed
  1c7180d

  Copy full SHA for 1c7180d

• Confirm error when namedtuple has widths OR edges

  halleysfifthinc

  committed
  66df7ad

  Copy full SHA for 66df7ad

• Confirm error in plotpeaks when first peak isnt an extrema

  halleysfifthinc

  committed
  4939c3d

  Copy full SHA for 4939c3d

• Update docstrings/doctests for utils functions

  halleysfifthinc

  committed
  862ad61

  Copy full SHA for 862ad61

• Add filterpeaks! to the docs

  halleysfifthinc

  committed
  adc1439

  Copy full SHA for adc1439

• Add julia cache to CI docs build

  halleysfifthinc

  committed
  925c9af

  Copy full SHA for 925c9af

• Dont try linking to Base docs (for the moment)

  halleysfifthinc

  committed
  b2ec0a6

  Copy full SHA for b2ec0a6

• fix errant ref

  halleysfifthinc

  committed
  f8b6f0e

  Copy full SHA for f8b6f0e