Remove unused ostruct
#97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Ruby 3.3.5, Bundler shows the following warning when using `ostruct`. ``` ostruct was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0. You can add ostruct to your Gemfile or gemspec to silence this warning. ``` Ref: https://bugs.ruby-lang.org/issues/20309 As the message described, we need to add `ostruct` to the gemspec to keep using it. But, it seems that `diff-lcs` doesn't use it. So I just remove `require of it.
halostatue
approved these changes
Sep 11, 2024
|
I will look at getting a minor version update released with this change later this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Ruby 3.3.5, Bundler shows the following warning when using
ostruct.Ref: https://bugs.ruby-lang.org/issues/20309
As the message described, we need to add
ostructto the gemspec to keep using it. But, it seems thatdiff-lcsdoesn't use it. So I just remove `require of it.