Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SSH tunnels #498

Merged
merged 4 commits into from
Dec 2, 2016
Merged

Remove SSH tunnels #498

merged 4 commits into from
Dec 2, 2016

Conversation

smondet
Copy link
Member

@smondet smondet commented Dec 2, 2016

Part of the autumn clean-up spree :)
#479 & #496

@smondet
Remove all the SSH tunnel management
8ca0097 
This includes:

- the holding of daemonized SSH processes,
- the WebUI tab,
- the text UI commands.

This fixes issue #496.
@smondet
Remove named hosts
5f77c8e 
They have become obsolete (#496).
@smondet
Remove SSH-tunnel/named-hosts from configuration
1c330e6 
This is both for #496 and #478.
@smondet
Update documentation of EDSL.Host.parse (#496)
ad0cac8
ihodes
ihodes reviewed Dec 2, 2016
View reviewed changes
src/pure/host.mli
@@ -149,5 +139,5 @@ val markup: t -> Display_markup.t
val execution_timeout: t -> Time.t option
(** The execution timeout configured for the host. *)

val connection: t -> [ `Localhost | `Ssh of Ssh.t | `Named of string ]
val connection: t -> [ `Localhost | `Ssh of Ssh.t ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we lose `Ssh, too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still use `Ssh _ for some stuff; then when an alternative raises and outperforms it (maybe part of coclobas, maybe independent), we'll be able to remove it.

@ihodes
Copy link
Member

ihodes commented Dec 2, 2016

Excited to see this go!

@smondet smondet merged commit ad0cac8 into master Dec 2, 2016
smondet added a commit that referenced this pull request Dec 2, 2016
@smondet
Merge PR #498 (@smondet, Remove SSH-tunnels #496)
c099314
@smondet smondet deleted the remove-ssh-tunnels branch May 31, 2017 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihodes ihodes ihodes left review comments

Assignees

@ihodes ihodes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smondet @ihodes