Added the ability to pass a function into pileup click handler #483
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@akmorrow13 I can't tell how to get the click test to work.
drawnObjectsWith(testDiv, '.pileup')
throws a failure even though if I comment out the other tests and remove the resets on testDiv and p, it displays fine in the browser.There seems to be a timing issue because sometimes
var canvasList = testDiv.getElementsByTagName('canvas');
has two elements and sometimes it doesn't. MaybehasPileupSelector
is not an appropriate wait for this test?I don't know how to get what offset I should provide to the
ReactTestUtils.Simulate.click
.Thanks for your help.
This change is