Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR refactors the
Response
class to improve consistency and readability in the factory method naming. The changes aim to make the naming scheme more intuitive and self-explanatory, ensuring that the purpose of each method is clear at a glance.Changes
Factory Method Renaming:
CreateResult
: Used for creating a successful user result response.CreateLibError
: Handles library internal errors.CreateUserError
: Handles user errors, allowing the user to specify error details.FromUserResponse
: Automatically creates either a result or error response based on the JSON object provided by the user.Code Structure:
.cpp
file, which enhances code readability and maintainability.Benefits
Testing
All existing tests have been updated to reflect the new method names and have been verified to pass.