Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAIN-T-117 Create endpoint to send Restore Password email #92

Merged

Conversation

hanna-eismant
Copy link
Owner

Add password reset feature with token generation and email notification

  • Implemented a password reset functionality that checks user existence, generates a reset password token, and sends an email notification with the reset password token.
  • Created relevant test cases and updated user service and user facade.
  • Added endpoint to reset password and updated JwtAuthorizationFilter for password reset endpoint.
  • Included new database table for storing reset password tokens.

Add password reset feature with token generation and email notification

 - Implemented a password reset functionality that checks user existence, generates a reset password token, and sends an email notification with the reset password token.
 - Created relevant test cases and updated user service and user facade.
 - Added endpoint to reset password and updated JwtAuthorizationFilter for password reset endpoint.
 - Included new database table for storing reset password tokens.
@hanna-eismant hanna-eismant self-assigned this Apr 25, 2024
Copy link

github-actions bot commented Apr 25, 2024

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

In the PasswordFacade class, a log statement and exception handling have been added to the reset password function. Now, when the password reset email is sent, it's wrapped in a try/catch block to handle any potential exceptions. Additionally, a debug-level log is generated whenever a rest password token is created.
Refactored the EmailService class to extract redundant code into a separate 'sendEmail' function. This makes the code easier to read and maintain. Additionally, removed unused variables in 'restore-password.html' and 'PasswordSpec.kt'.
@hanna-eismant hanna-eismant merged commit 463a396 into main Apr 25, 2024
5 checks passed
@hanna-eismant hanna-eismant deleted the MAIN-T-117-Create-endpoint-to-send-Restore-Password-email branch April 25, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant