MAIN-T-120 Add JavaDocs #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing DocumentFacade class has been refactored to an interface. The DefaultDocumentFacade class is created as its implementation. In addition, classes for authentication request and response have been implemented to handle authorization requests. The commit also includes changes in the test classes for documents and authorization accordingly.
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
The commit primarily updates the naming convention of service implementations for better clarity. The prefix 'Default' has been appended to service implementations to differentiate them from service interfaces. Further, some services that were previously implemented directly in the service interface have been refactored to follow the interface-implementation design principle. This commit enhances the readability and organization of codebase, promoting better maintenance in the future.
The commit reflects major refactoring across server-side code. Important code structures like services and facades have been refactored into interfaces and default implementations. This improves the overall code structure by separating contract and implementation. Furthermore, the commit also includes renaming of several classes and methods for better consistency across the codebase. Throughout the changes, all necessary adjustments have been made in corresponding test classes to align with the refactorings.
Added descriptive comments to various classes and methods across the codebase. This includes service interfaces, controllers, entities, and other components. The aim is to provide a better understanding of the purpose and functionality of each component.
`MockUserEntityRepository` has been introduced in the `DefaultUserServiceTest` to provide mock implementations for `UserEntityRepository` methods. It replaces the previous mock setup with a more detailed and manageable mock configuration. The class is designed to be extendable for specific testing situations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor document management and implement authentication request
The existing
DocumentFacadeclass has been refactored to an interface. TheDefaultDocumentFacadeclass is created as its implementation. In addition, classes for authentication request and response have been implemented to handle authorization requests. The commit also includes changes in the test classes for documents and authorization accordingly.