-
-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backend: PetAPI V2 #3474
Open
DavidArthurCole
wants to merge
114
commits into
hannibal002:beta
Choose a base branch
from
DavidArthurCole:PetAPIV2
base: beta
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Backend: PetAPI V2 #3474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/java/at/hannibal2/skyhanni/config/commands/Commands.kt
# Conflicts: # src/main/java/at/hannibal2/skyhanni/features/misc/pets/CurrentPetDisplay.kt
# Conflicts: # src/main/java/at/hannibal2/skyhanni/config/storage/ProfileSpecificStorage.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Continuation PR of #2605, reforming the PetAPI in preparations for overhauling the active pet display. This does a little more work on top of what @martimavocado had done, to clean up the way data is being populated - as such, this PR is based on his branch.
What was previously
PetAPI
has now been split into:PetData
CurrentPetAPI
PetUtils
Changelog Technical Details
CurrentPetAPI
,PetUtils
, andPetData
.