Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LWT 2.0 #4

Open
wants to merge 601 commits into
base: master
Choose a base branch
from
Open

LWT 2.0 #4

wants to merge 601 commits into from

Conversation

HugoFara
Copy link

@HugoFara HugoFara commented Feb 21, 2022

Hello,

I have been maintaining LWT for a few months, integrating official updates and adding significant changes, and I think that your branch would greatly benefit from a merge.

A great deal of things changed through years, so I would be able to give a clear insight here. Hence, I won't be able to give all details here, but I would appreciate to clarify any concern.

Regarding the official LWT (from original developer): this pull request brings everything from version 1.4.5 to 2.0.2. It includes important fixes with PHP 8.0+, important reviews for the printed text version, and many, many bug fixes.

From the community, numerous changes and improvements were added (versions 1.6.0-fork to 2.2.2-fork):

  • Use news feed as a source of content
  • Display reviewed for modern internet
    • LWT use much less iframes
    • It reduces security concerns
    • LWT can now be displayed on mobile devices
  • Much smaller database
  • Code separated from logic, solving Separate view from logic #1
  • Use of functions instead of imperative code. Some files were also refactored such as utilities.inc.php, solving Redistribute utilities.inc.php functions #3 .

Warning: due to the new database size, you will have to convert your database. Fortunately, a script can convert your database to the new system, and another can backup your database to the old one.

I mistakenly created this draft pull request (I would have like to purge the documentation from it). As we are here, would you like to discuss about this merge? Otherwise I can do a cleaner pull request.

Regards

LWT Project and others added 30 commits January 27, 2016 22:30
	Database changes : dropped: index WtWoID, index TtTxID, index AgAtID
		RegExp Word Characters are checked for correct syntax when creating/updating language.
		Thumbnail/image support removed.
Bugfix: Access denied, LOAD DATA INFILE error (text parsing on a server).
Bugfix: 'remove spaces' not working.
Wizard Language Defaults changed.
In appreviations like 'Mr.' the dot is now part of the term. A reparse of texts is needed to take effect.
Wizard Language: Arabic 'RegExp Word Characters' changed.
		New Feature: MECAB support (in development).
all_words_welknown.php was errored and could only throw errors.
It has no comment nor linting.
Now things are starting to be clear.
In edit_texts.php, it was not displayed when knowing 1 word.
A bit of refactoring in edit_texts.
In edit_texts.php, unknown words (with status 0), had no abbreviation.
Commented unnused code in news feed.
@HugoFara HugoFara marked this pull request as ready for review April 27, 2022 05:59
@hans
Copy link
Owner

hans commented Apr 27, 2022

Hi, I created this repo a decade ago to make some small bugfixes to LWT code, but have never been properly involved in the LWT project.
Looking back now, it seems like I accidentally became the root of a productive tree of GitHub forks .. :)

In any case, my repository shouldn't be taken as authoritative. I suggest you get in touch with the original LWT author at https://learning-with-texts.sourceforge.io/ .

@HugoFara
Copy link
Author

Hi, I knew that a pull request on a repo almost a decade after the last commit is quite unusual.

As I have been continuing the development of the community version of LWT, would you like to get in touch? It is not easy for newcomers to GitHub to know which fork they should use. The original author of LWT stated several times that he won't do a GitHub version, so it may be better to keep the "official" version of LWT on sourceforge, while the community continues on GitHub.

@threddast
Copy link

Any news regarding this? As a newcomer, it's really a mess to navigate between all the existing versions of LWT and it would be helpful to have a "main" community version on github

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants