fix data types for fileLoc and diskLoc in tools code and fix reading of json floats on non-US locales #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fileLoc gets truncated if the json is saved as it can easily be larger than a signed 32-bit integer can store
diskLoc should have decimal places according to @happycube and is output with them from the python code. (Though it's not super useful at the moment and maybe not accurate either if there is data in the input before the start of the disk since it's just fileLoc divided by lines per field with the current code)
std::stod(and related) is locale-dependent at least on linux annoyingly so on many non-US locales it will not interpret.as the decimal separator and thus load floating point values as integers - so changed to use functions that avoids that.We may want to consider switching a proper json library though which would probably be way more efficient