FEATURE/MINOR: kubernetes-ingress: Parametrize metrics service type #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds `controller.service.metrics.type` so that the metrics service's type can be parametrized. The value defaults to `ClusterIP` for backwards compatibility with previous versions of the Helm chart.
mecampbellsoup
deleted the
mc/kube-ingress/add/metrics-service-type-value
branch
dkorunic
added a commit
that referenced
this pull request
Apr 4, 2024
Changes in kubernetes-ingress: - Use Ingress Controller 1.11.3 version for base image - Add more permissions needed for techdump tool - Parametrize metrics service type (#231) - Require K8s >= 1.23.0 Signed-off-by: Dinko Korunic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
controller.service.metrics.typeso that the metrics service's type can be parametrized. The value defaults toClusterIPfor backwards compatibility with previous versions of the Helm chart.We need the ability to do this because of a bug in
external-dnsbut we unfortunately are not immediately able to upgradeexternal-dnsto fix this bug.