Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG/MINOR: prevents unconditional restarts when prometheus is enabled #626

Conversation

fabianonunes
Copy link
Contributor

@fabianonunes fabianonunes commented Mar 9, 2024

When the --prometheus flag is passed, the Prometheus backend check always fails if the controller namespace isn't haproxy-controller. Consequently, all events received by the controller trigger a hard restart of HAProxy.

2024/03/09 12:32:14 INFO    instance/configuration.go:21 [transactionID=8a5a139f-1b65-4faf-8e40-dc467a54dcfb] reload required : creation/modification of prometheus endpoint

Since the backend name depends on the namespace, it shouldn't be hardcoded.

When the --prometheus flag is passed, the backend check always fails
because its name is incorrect in the code. So, all events received
by the controller trigger a restart of HAProxy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant