BUG/MINOR: prevents unconditional reloads when prometheus is enabled and controller namespace isn't haproxy-controller
#627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianonunes
force-pushed
the
prevents-unconditional-reloads
branch
from
8e5a7ed to
e0becb5
Compare
fabianonunes
changed the title
haproxy-controller
fabianonunes
changed the title
haproxy-controllerhaproxy-controller
When the --prometheus flag is passed, the Prometheus backend check always fails if the controller namespace isn't haproxy-controller. Consequently, all events received by the controller trigger a reload of HAProxy. Since the backend name depends on the namespace, it shouldn't be hardcoded.
fabianonunes
force-pushed
the
prevents-unconditional-reloads
branch
from
e0becb5 to
5f9d7c5
Compare
|
@fabianonunes thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
--prometheusflag is passed, the Prometheus backend check always fails if the controller namespace isn'thaproxy-controller. Consequently, all events received by the controller trigger a reload of HAProxy.Since the backend name depends on the namespace, it shouldn't be hardcoded.