MINOR: fix info message when global config is updated #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Olivier Doucet <[email protected]>
odoucet
force-pushed
the
fix-globalconfig-infomessage
branch
from
46cf54a to
47c6e75
Compare
Signed-off-by: Olivier Doucet <[email protected]>
|
Hello, |
|
hi @odoucet sorry for a bit late response. this looks good, thx for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is refering to #652
CAREFUL
I am absolutely not familiar with Go language (I'm a PHP guy). I tried to be very careful but please read my code carefully before accepting the commit.
EXPLANATIONS
I removed the unused
updatedvariable and fixed the error message. I just used the same syntax as line 149.I also used
%+vto show field name (more explicit).