Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require six >= 1.11.0 #245

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Require six >= 1.11.0 #245

wants to merge 1 commit into from

Conversation

avdv
Copy link

@avdv avdv commented Dec 2, 2020

It is not good practice pinning versions in install_requires, it should only define
minimal required versions.

See https://packaging.python.org/discussions/install-requires-vs-requirements/

It is not considered best practice to use install_requires to pin dependencies to specific versions, or to specify sub-dependencies (i.e. dependencies of your dependencies). This is overly-restrictive, and prevents the user from gaining the benefit of dependency upgrades.

It is not good practice pinning versions in `install_requires`, it should only define
minimal required versions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant