Sync with 2.8.1 #81
Merged
Sync with 2.8.1 #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notgull
approved these changes
Sep 10, 2023
| LangTag { language: "zln", tag: Tag::from_bytes(b"ZHA ") }, // Lianshan Zhuang -> Zhuang | ||
| LangTag { language: "zlq", tag: Tag::from_bytes(b"ZHA ") }, // Liuqian Zhuang -> Zhuang | ||
| LangTag { language: "zmi", tag: Tag::from_bytes(b"MLY ") }, // Negeri Sembilan Malay -> Malay | ||
| LangTag { language: "zmz", tag: Tag::from_bytes(b"BAD0") }, // Mbandja -> Banda | ||
| LangTag { language: "znd", tag: Tag(0) }, // Zande [family] != Zande | ||
| LangTag { language: "zne", tag: Tag::from_bytes(b"ZND ") }, // Zande | ||
| LangTag { language: "zne", tag: Tag::from_bytes(b"ZND ") }, // Zande |
There was a problem hiding this comment.
Yeah, I have no idea why rustfmt doesn’t strip the trailing space from the comment.
There was a problem hiding this comment.
Just remove them manually for now. In my editor I have "remove trailing whitespaces" feature, so it's being trimmed automatically.
|
This change was already present? Weird. |
|
Looks good to me too. Luckily for us, this version contains mostly subsetter changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the changes had to do with subsetting and abstractions not used by rustybuzz (e.g.
OffsetTotypes), so this is pretty small.