Make HTTP API listen on 0.0.0.0 like other services #87
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Makes the HTTP API listen on 0.0.0.0 like the rest of the services :)
This is required mainly to allow every service to operate inside of a container, where 127.0.0.1 isn't very useful as you can't hit the service from the outside.
Issues
Fixes #86
How to test
Run the application as normal with your desired config. Here's an example config based on the one I'm using for my app:
Command like the I'm using to run this locally:
cargo run --bin xiu -- -c ~/path/to/your/config.toml
You should see the http api now listed as running on 0.0.0.0:8000 or however you've configured it.
Next Steps
I just wanted to get this out there for now, but soon I'd like to make a PR that adds a
--host
as well ashost
or maybeaddress
config options to each of the target services to make this truly customizable for any strange configuration end users might need :)