Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Hindi Translation #68

Merged
merged 5 commits into from
Aug 24, 2023
Merged

Conversation

anjanraj027
Copy link
Contributor

I love this app and wanted to contribute towards it and i believe there are many users who would love this app in my country.
so, I added Hindi translation for Indian Users.

@mytja
Copy link
Member

mytja commented Aug 24, 2023

One small comment before anybody merges this. This is Hindi translation for India. Shouldn't the filename therefore be hi_IN.json instead of hi_HI.json?

Also feel free to add yourself as a contributor to the README as stated in it.

I don't know Hindi by any means so @alexmercerind might want to look into it.

@alexmercerind alexmercerind marked this pull request as draft August 24, 2023 14:34
@anjanraj027
Copy link
Contributor Author

@mytja Sorry for the mistake, Now i've renamed the json file to hi_IN.json as you mentioned.
thanks for pointing out my mistake..

@anjanraj027 anjanraj027 marked this pull request as ready for review August 24, 2023 15:58
@mytja
Copy link
Member

mytja commented Aug 24, 2023

Sorry for bothering you so much, but some specific words spelled in all caps & wrapped inside quotations, including but not limited to NAME in COLLECTION_TRACK_DELETE_DIALOG_BODY or TRACK_NAME in COLLECTION_TRACK_PLAYLIST_REMOVE_DIALOG_BODY should not be changed. These are used internally within Harmonoid to integrate track names etc. directly into the language string

I have to go right now, so I won't be available for a couple of hours.

@alexmercerind
Copy link
Member

alexmercerind commented Aug 24, 2023

Thanks for taking your time @mytja, feel free to leave the charge.

You may unsubscribe to the thread for avoiding redundant mails.


@anjanraj027 thanks for the PR.

@maisondasilva maisondasilva merged commit 6c5d372 into harmonoid:master Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants