Allow users to pass custom data between chains #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…target events from specific contract address
…ey actually show up in topics
…d from on other chain, for proper permissioning support
|
On more deliberation, I have decided to separate the functionality. Added helper functions to reduce code duplication to the best of my ability. |
…tx internal function
…alidate and execute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the event structure for mint/burn ect events to add an event where any user can emit an event that will allow code to be executed on the other chain.
User must call the validateAndExecuteProof function separately providing the contract address to listen for events from. The event passes the address to call and a bytes array of arbitrary data. The bridge contract then calls the specified address with the function signature HorizonExecute(address,bytes). The address passed is the address of the contract on the other side of the bridge that emitted the event. This allows permissioning of the other side contract specifcally, so that not any contract can emit the event and trigger behavior of contracts on the other chain.
Leaving this PR in draft for now because I am having problems getting the proof generated from the DagProof CLI file to be verified by the validateMPTProof of EthereumProver.sol, therefore preventing me from accessing and testing any of the new code for this feature at the mement.