Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues in forms components and change settings layout #675

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

3em
Copy link
Collaborator

@3em 3em commented Jan 15, 2025

  • Made changes to the MultiSelect component
  • Updated the "Target Patterns" section in the Rules form
  • Added a skeleton loader for forms
  • Added a "Not Found" view state to forms pages
  • Updated the Settings layout and created a new layout component: ContentLayoutWithSidebar
  • Added previews for General Settings, Rule Form, and "Not Found Rule" pages

image
image
image

@3em 3em requested a review from knagurski as a code owner January 15, 2025 11:39
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

netlify bot commented Jan 15, 2025

Deploy Preview for harness-xd-review ready!

Name Link
🔨 Latest commit 080c61d
🔍 Latest deploy log https://app.netlify.com/sites/harness-xd-review/deploys/67879e75adfc450008eac033
😎 Deploy Preview https://deploy-preview-675--harness-xd-review.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants