Turn on nullable and remove as many warnings as possible #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am aware this will involve many merge conflicts as other PRs get merged. That's fine. I'm okay with that. :") |
|
Also if you think this sucks, it's fine if we remove it lol. |
|
This causes too many bugs... I think I'm gonna abandon it, despite it taking me hours to do lol. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I apologize in advance for this one. 161 files changed, jesus.
We have like 50 warnings in the build currently about using nullables in a non-nullable context. So I flipped on nullable context (because it is useful!) and went through our code to fix up every nullable warning I could. :)